Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meter block value types #16

Open
marpi82 opened this issue Aug 5, 2020 · 1 comment · May be fixed by #22
Open

Meter block value types #16

marpi82 opened this issue Aug 5, 2020 · 1 comment · May be fixed by #22
Assignees

Comments

@marpi82
Copy link

marpi82 commented Aug 5, 2020

I have noticed that these values isn't correct (they should be "signed int" no "unsigned"):

#40211 Apparent Power
m1_ac_va = data.decode_16bit_uint()

#40216 Reactive Power
m1_ac_var = data.decode_16bit_uint()

#40221 Power Factor
m1_ac_pf = data.decode_16bit_uint()

I have also suggestion about configuration becouse most of people have configured modbus unit as 1 (first device), but I have as second. Could You made a little modification to configure these from hass

I say about these line (unit_id)

client = ModbusClient(host, port=port, unit_id=1, auto_open=True)

@erikarenhill erikarenhill self-assigned this Mar 1, 2021
@erikarenhill erikarenhill linked a pull request Mar 1, 2021 that will close this issue
@erikarenhill
Copy link
Owner

@marpi82 should be fixed with this PR, do you have the possibility to test this pr/branch to verify functionality before I merge? I don't have a separate meter to do this on my own. #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants