Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TxPool: txpool_content must not return blob txs #12864

Open
AskAlexSharov opened this issue Nov 25, 2024 · 1 comment
Open

TxPool: txpool_content must not return blob txs #12864

AskAlexSharov opened this issue Nov 25, 2024 · 1 comment
Labels
dencun The Deneb/Cancun protocol upgrade erigon3 imp2 Medium importance support

Comments

@AskAlexSharov
Copy link
Collaborator

I see geth does:

func (p *BlobPool) Content() (map[common.Address][]*types.Transaction, map[common.Address][]*types.Transaction) {
	return make(map[common.Address][]*types.Transaction), make(map[common.Address][]*types.Transaction)
}
func (p *BlobPool) ContentFrom(addr common.Address) ([]*types.Transaction, []*types.Transaction) {
	return []*types.Transaction{}, []*types.Transaction{}
}
func (p *BlobPool) Locals() []common.Address {
	return []common.Address{}
}

Seems same need for: txpool_contentFrom and txpool_locals

@yperbasis
Copy link
Member

But does the spec say that txpool_content should not return blob txns?

@yperbasis yperbasis added the imp2 Medium importance label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dencun The Deneb/Cancun protocol upgrade erigon3 imp2 Medium importance support
Projects
None yet
Development

No branches or pull requests

2 participants