Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support connecting to unix domain sockets #49

Open
slingamn opened this issue May 29, 2024 · 1 comment
Open

support connecting to unix domain sockets #49

slingamn opened this issue May 29, 2024 · 1 comment

Comments

@slingamn
Copy link
Member

Including http+unix URLs --- nice potential enhancement for debugging

@slingamn
Copy link
Member Author

slingamn commented Jul 14, 2024

We already support this for IRC connections, e.g. ircdog /tmp/oragono_socket works as expected.

Supporting websockets is nontrivial. It's vaguely possible to hack this into Gorilla, but as it turns out, url.Parse doesn't like http+unix URLs with percent-encoded hostnames, so we get tripped up here:

ircdog/ircdog.go

Lines 106 to 110 in 71e3129

u, uErr := url.Parse(host)
if uErr != nil {
err = fmt.Errorf("Invalid host: %w", uErr)
return
}

Probably not worth it at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant