Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc improvements related to allow config branch not mapped in environment #1136

Merged
merged 5 commits into from
Nov 19, 2024
Merged

Misc improvements related to allow config branch not mapped in environment #1136

merged 5 commits into from
Nov 19, 2024

Conversation

nilsgstrabo
Copy link
Contributor

@nilsgstrabo nilsgstrabo commented Nov 14, 2024 •
edited
Loading

  • Add link in "Create new app" registration form to new apply-config pipeline job
  • Add link in app/env form to new apply-config pipeline job when there are no environments (radixconfig not applied)
  • Do not use config branch as default branch in build-deploy pipeline job when there are no environments
  • Update all links to external URLs to open in new window (use new ExternalLink component)
  • Fix link to service principals in configuration page

@nilsgstrabo nilsgstrabo self-assigned this Nov 14, 2024
@nilsgstrabo nilsgstrabo mentioned this pull request Nov 14, 2024
Closed
3 tasks
@nilsgstrabo nilsgstrabo mentioned this pull request Nov 15, 2024
Open
@nilsgstrabo nilsgstrabo changed the title use apply-config as initial pipeline job Misc improvements related to allow config branch not mapped in environment Nov 15, 2024
Richard87
Richard87 approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@Richard87 Richard87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Richard87 Richard87 linked an issue Nov 19, 2024 that may be closed by this pull request
Change how links work in web console #1048
Open
@Richard87 Richard87 removed a link to an issue Nov 19, 2024
Change how links work in web console #1048
Open
@nilsgstrabo nilsgstrabo marked this pull request as ready for review November 19, 2024 14:27
@nilsgstrabo nilsgstrabo merged commit 390e051 into master Nov 19, 2024
5 checks passed
@nilsgstrabo nilsgstrabo deleted the info-initial-pipeline-job branch November 20, 2024 07:21
@emirgens emirgens linked an issue Nov 27, 2024 that may be closed by this pull request
Links to external URLs should open in new browser tab #1137
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Richard87 Richard87 Richard87 approved these changes

Assignees

@nilsgstrabo nilsgstrabo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Links to external URLs should open in new browser tab
2 participants
@nilsgstrabo @Richard87