Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add endpoint for stream configs #645

Closed
wants to merge 1 commit into from
Closed

Add endpoint for stream configs #645

wants to merge 1 commit into from

Conversation

andchiind
Copy link
Contributor

No description provided.

@andchiind andchiind added the improvement Improvement to existing functionality label Nov 21, 2024
@andchiind andchiind self-assigned this Nov 21, 2024
@sondreo sondreo self-requested a review November 25, 2024 11:35
sondreo
sondreo requested changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@sondreo sondreo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on the new endpoint! See some suggestions and questions.

src/isar/apis/robot_control/robot_controller.py Show resolved Hide resolved
src/isar/apis/robot_control/robot_controller.py Show resolved Hide resolved
src/isar/modules.py Show resolved Hide resolved
src/isar/apis/robot_control/robot_controller.py Show resolved Hide resolved
src/isar/services/utilities/robot_utilities.py Show resolved Hide resolved
@andchiind
Copy link
Contributor Author

Migrated to new branch https://github.com.mcas.ms/equinor/isar/pull/651

@andchiind andchiind closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sondreo sondreo sondreo requested changes

Assignees

@andchiind andchiind

Labels
improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andchiind @sondreo