Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get isar-robot to fail some tasks #83

Open
7 of 8 tasks
Eddasol opened this issue Aug 25, 2023 · 7 comments
Open
7 of 8 tasks

Get isar-robot to fail some tasks #83

Eddasol opened this issue Aug 25, 2023 · 7 comments
Assignees
Labels
good first issue Good for newcomers improvement Improvement to existing functionality question Further information is requested stale

Comments

@Eddasol
Copy link
Contributor

Eddasol commented Aug 25, 2023

Get isar-robot to fail some task such that testing through isar-robot will touch larger parts of the code and to allow for testing of failure behaviour.

One option is to use environment variables to decide if it should fail or not.

Some different types of isar-robot that could have different behaviour:

  • PlaceBot (successfully completes every task after x seconds)
  • NoceBot (regular missions always fails)
  • LostBot (localization step always fails)
  • SlowBot (spends 1 minute per task)
  • InstantBot (spends no time per task)
  • VagaBot (never returns home)
  • OfflineBot (Shuts down mid mission)

Prerequisite

@Eddasol Eddasol added question Further information is requested improvement Improvement to existing functionality labels Aug 25, 2023
@andchiind
Copy link

This would be very useful for equinor/flotilla#894 and issue #871 in general

@Christdej
Copy link
Contributor

Would it be an idea to have a mission with a specific ID or a certain step that will cause isar-robot to send and error back or mark mission as failed?

@Christdej
Copy link
Contributor

Or make isar-robot configurable to always succeed or always fail, and run one of each instances in dev

@tsundvoll tsundvoll self-assigned this Nov 13, 2023
@tsundvoll
Copy link
Contributor

tsundvoll commented Nov 13, 2023

Will solve this using the Mission.name attribute to decide if a mission should fail some tasks, by reporting step.status = StepStatus.Failed

@tsundvoll
Copy link
Contributor

Can this be tested with an integration test from ISAR?

@tsundvoll tsundvoll added the good first issue Good for newcomers label Mar 5, 2024
@tsundvoll tsundvoll removed their assignment Mar 18, 2024
@haakonsf haakonsf self-assigned this Mar 19, 2024
@haakonsf
Copy link
Contributor

@aeshub
Copy link
Contributor

aeshub commented Jul 15, 2024

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers improvement Improvement to existing functionality question Further information is requested stale
Projects
None yet
Development

No branches or pull requests

6 participants