From 06acd49db1508d14812882b159a51ed1f1048faa Mon Sep 17 00:00:00 2001 From: Christopher Berge Hove Date: Thu, 24 Oct 2024 13:33:03 +0200 Subject: [PATCH] refactor: Remove unused properties in PortalRequest and AppCategory types --- .../core/src/modules/portal-config/types/index.ts | 4 ---- .../core/src/modules/portal-config/utils/utils.test.ts | 8 ++++---- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/client/packages/core/src/modules/portal-config/types/index.ts b/client/packages/core/src/modules/portal-config/types/index.ts index c906551f..aa942cdb 100644 --- a/client/packages/core/src/modules/portal-config/types/index.ts +++ b/client/packages/core/src/modules/portal-config/types/index.ts @@ -26,9 +26,6 @@ export type PortalRequest = { subtext?: string; contexts?: ContextType[]; apps?: string[]; - // todo remove routes and extensions - routes?: PortalRouter; - extensions?: Extensions; configuration: { environment: string | null; extension: string | null; @@ -56,7 +53,6 @@ export type PortalRouteWithChildren = PortalRoute & { export type AppCategory = { id?: string; - // name: string | null; displayName: string | null; color: string | null; defaultIcon: string | null; diff --git a/client/packages/core/src/modules/portal-config/utils/utils.test.ts b/client/packages/core/src/modules/portal-config/utils/utils.test.ts index 33bbb4ef..b66f0b52 100644 --- a/client/packages/core/src/modules/portal-config/utils/utils.test.ts +++ b/client/packages/core/src/modules/portal-config/utils/utils.test.ts @@ -3,7 +3,7 @@ import { AppManifest, AppCategory } from '@portal/core'; import { getColumnCount } from './utils'; const appGroups: AppCategory[] = [ { - name: 'Group 1', + displayName: 'Group 1', apps: [ { appKey: 'Test1' } as AppManifest, { appKey: 'Test2' } as AppManifest, @@ -16,7 +16,7 @@ const appGroups: AppCategory[] = [ ], } as AppCategory, { - name: 'Group 2', + displayName: 'Group 2', apps: [ { appKey: 'Test9' } as AppManifest, { appKey: 'Test10' } as AppManifest, @@ -29,7 +29,7 @@ const appGroups: AppCategory[] = [ ], } as AppCategory, { - name: 'Group 3', + displayName: 'Group 3', apps: [ { appKey: 'Test17' } as AppManifest, { appKey: 'Test18' } as AppManifest, @@ -39,7 +39,7 @@ const appGroups: AppCategory[] = [ ]; const singleAppGroup: AppCategory[] = [ { - name: 'Group 1', + displayName: 'Group 1', apps: [{ appKey: 'testSingleApp' } as AppManifest], } as AppCategory, ];