fix(http)!: throw correct error in jsonSelector

[odinr]

Why

This pull request introduces a fix to the jsonSelector function in the @equinor/fusion-framework-module-http package.

The current behavior is that the jsonSelector function was not properly checking the error type in the catch block. This led to always throwing a parser error, even when the correct error was in the cause property of the HttpJsonResponseError.

The new behavior is that the jsonSelector function now correctly checks if the error is an instance of HttpJsonResponseError, and then properly handles the error data and cause. This ensures that developers who have caught the error and assumed the cause property would give the proper error data, will now receive the correct information.

This change might introduce breaking changes:
If for some reason developers has catched the error and assumed the cause property would give the proper error data, this will no longer be the case.

try {
  await jsonSelector(response);
} catch (error) {
  if(error instanceof HttpJsonResponseError) {
-    const data = error.cause instanceof HttpJsonResponseError ? err.cause.data : null;
+    const data = error instanceof HttpJsonResponseError ? error.data : null;
    if(data) {
      console.error('the request was not `ok`, see provided error data', data);
    } else {
      console.error('failed to parse data from response, see provided cause', error.cause);
    }
  }
}

Check off the following:

• Confirm that I checked changes to branch which I am merging into.
  • I have validated included files
  • My code does not generate new linting warnings
  • My PR is not a duplicate, check existing pr`s
• Confirm that the I have completed the self-review checklist.
• Confirm that my changes meet our code of conduct.

[changeset-bot]

🦋 Changeset detected

Latest commit: 347a823

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 21 packages

Name	Type
@equinor/fusion-framework-module-http	Patch
@equinor/fusion-framework-app	Patch
@equinor/fusion-framework-cli	Patch
@equinor/fusion-framework	Patch
@equinor/fusion-framework-module-service-discovery	Patch
@equinor/fusion-framework-module-widget	Patch
@equinor/fusion-framework-legacy-interopt	Patch
@equinor/fusion-framework-react-module-http	Patch
@equinor/fusion-framework-widget	Patch
@equinor/fusion-framework-cookbook-app-react-feature-flag	Patch
@equinor/fusion-framework-react-app	Patch
@equinor/fusion-framework-cookbook-app-react-context-custom-error	Patch
@equinor/fusion-framework-cookbook-app-react-context	Patch
@equinor/fusion-framework-react	Patch
@equinor/fusion-framework-react-widget	Patch
@equinor/fusion-framework-react-components-bookmark	Patch
@equinor/fusion-framework-react-components-people-provider	Patch
@equinor/fusion-framework-react-module-bookmark	Patch
@equinor/fusion-framework-module-signalr	Patch
@equinor/fusion-framework-react-module-signalr	Patch
@equinor/fusion-framework-react-module-context	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	12.74%	3682 / 28882
🔵	Statements	12.74%	3682 / 28882
🔵	Functions	12.67%	92 / 726
🔵	Branches	27.27%	225 / 825

File Coverage

File	Stmts	% Branch	% Funcs	% Lines	Uncovered Lines
Changed Files
packages/modules/http/src/lib/selectors/json-selector.ts	39.58%	100%	0%	39.58%	18-46

Generated in workflow #6322