Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crashing if process.env is undefined #2106

Closed
wants to merge 2 commits into from

Conversation

Gustav-Eikaas
Copy link
Collaborator

@Gustav-Eikaas Gustav-Eikaas commented Apr 29, 2024

Context:

Fixes a bug we encountered in equinor/cc-components where apps would fail in the test environment with an error message of failed to read property of undefined. process.env.....

Line that errored in production
image

Solution

Added conditional access (?.) to process.env.fusion_log_level

Impact

No changes required by consumers

Copy link

changeset-bot bot commented Apr 29, 2024

🦋 Changeset detected

Latest commit: 2d53187

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@equinor/fusion-query Patch
@equinor/fusion-framework-cli Patch
@equinor/fusion-framework-module-app Patch
@equinor/fusion-framework-module-bookmark Patch
@equinor/fusion-framework-module-context Patch
@equinor/fusion-framework-module-service-discovery Patch
@equinor/fusion-framework-module-widget Patch
@equinor/fusion-framework-react-components-people-provider Patch
@equinor/fusion-framework-react-module-bookmark Patch
@equinor/fusion-framework-react-module-context Patch
@equinor/fusion-framework-cookbook-app-react-context-custom-error Patch
@equinor/fusion-framework-cookbook-app-react-context Patch
@equinor/fusion-framework-cookbook-app-react-feature-flag Patch
@equinor/fusion-framework-app Patch
@equinor/fusion-framework-react-app Patch
@equinor/fusion-framework-react-components-bookmark Patch
@equinor/fusion-framework-react Patch
@equinor/fusion-framework-legacy-interopt Patch
@equinor/fusion-framework Patch
@equinor/fusion-framework-module-signalr Patch
@equinor/fusion-framework-react-widget Patch
@equinor/fusion-framework-widget Patch
@equinor/fusion-framework-react-module-signalr Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 🐞 bug Something isn't working 🛠️ utils packages related to utils labels Apr 29, 2024
@Gustav-Eikaas Gustav-Eikaas marked this pull request as ready for review April 29, 2024 06:58
@Gustav-Eikaas Gustav-Eikaas requested review from odinr and a team as code owners April 29, 2024 06:58
@github-actions github-actions bot added the 🚧 chore maintaines work, (update deps, workflos ...) label Apr 29, 2024
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 11.23% 3453 / 30733
🔵 Statements 11.23% 3453 / 30733
🔵 Functions 10.89% 84 / 771
🔵 Branches 24.09% 207 / 859
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/utils/query/src/logger.ts 92% 63.63% 71.42% 92% 72-79, 115-116
Generated in workflow #5746

@Gustav-Eikaas Gustav-Eikaas self-assigned this Apr 29, 2024
@eikeland
Copy link
Contributor

@odinr odinr closed this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 🚧 chore maintaines work, (update deps, workflos ...) 🛠️ utils packages related to utils
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants