Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(module-http): prevent modification to config #2043

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

odinr
Copy link
Collaborator

@odinr odinr commented Apr 5, 2024

Why

see changeset

Check off the following:

  • Confirm that I checked changes to branch which I am merging into.

    • I have validated included files
    • My code does not generate new linting warnings
    • My PR is not a duplicate, check existing pr`s
  • Confirm that the I have completed the self-review checklist.

  • Confirm that my changes meet our code of conduct.

Copy link

changeset-bot bot commented Apr 5, 2024

🦋 Changeset detected

Latest commit: a2947a8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 21 packages
Name Type
@equinor/fusion-framework-module-http Patch
@equinor/fusion-framework-app Patch
@equinor/fusion-framework-cli Patch
@equinor/fusion-framework Patch
@equinor/fusion-framework-module-service-discovery Patch
@equinor/fusion-framework-module-widget Patch
@equinor/fusion-framework-legacy-interopt Patch
@equinor/fusion-framework-react-module-http Patch
@equinor/fusion-framework-widget Patch
@equinor/fusion-framework-cookbook-app-react-feature-flag Patch
@equinor/fusion-framework-react-app Patch
@equinor/fusion-framework-cookbook-app-react-context-custom-error Patch
@equinor/fusion-framework-cookbook-app-react-context Patch
@equinor/fusion-framework-react Patch
@equinor/fusion-framework-react-widget Patch
@equinor/fusion-framework-react-components-bookmark Patch
@equinor/fusion-framework-react-components-people-provider Patch
@equinor/fusion-framework-react-module-bookmark Patch
@equinor/fusion-framework-module-signalr Patch
@equinor/fusion-framework-react-module-signalr Patch
@equinor/fusion-framework-react-module-context Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 🐞 bug Something isn't working 🚀 feature New feature or request 🧬 Modules labels Apr 5, 2024
@odinr odinr marked this pull request as ready for review April 8, 2024 06:25
@odinr odinr requested a review from a team as a code owner April 8, 2024 06:25
@odinr odinr force-pushed the fix/module/http/prevent-modification-to-config branch from b63f040 to a2947a8 Compare April 8, 2024 06:54
Copy link
Contributor

github-actions bot commented Apr 8, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 7.13% 2073 / 29044
🔵 Statements 7.13% 2073 / 29044
🔵 Functions 7.54% 56 / 742
🔵 Branches 16.62% 128 / 770
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/modules/http/src/lib/client/client.ts 46.56% 100% 11.76% 46.56% 51-52, 69-73, 76-80, 84-88, 91-105, 108-112, 115-123, 126-127, 131-135, 138-143, 146-147, 150-190, 193-194, 197-198, 201-203
packages/modules/http/src/lib/operators/process-operators.ts 93.61% 90.9% 66.66% 93.61% 45-48, 67-68
packages/modules/http/src/lib/operators/types.ts 100% 100% 100% 100%
Generated in workflow #5391

@odinr odinr self-assigned this Apr 8, 2024
@odinr odinr merged commit 4af517f into main Apr 8, 2024
9 checks passed
@odinr odinr deleted the fix/module/http/prevent-modification-to-config branch April 8, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 🚀 feature New feature or request 🧬 Modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants