Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(PeopleResolver): remove todo #1745

Merged
merged 1 commit into from
Feb 1, 2024
Merged

chore(PeopleResolver): remove todo #1745

merged 1 commit into from
Feb 1, 2024

Conversation

Noggling
Copy link
Collaborator

  • Removed todo from the PeopleResolve
  • Add fallback to PeopleResolveProviderProps

Why

closes:

Check off the following:

  • Confirm that I checked changes to branch which I am merging into.

    • I have validated included files
    • My code does not generate new linting warnings
    • My PR is not a duplicate, check existing pr`s
  • Confirm that the I have completed the self-review checklist.

  • Confirm that my changes meet our code of conduct.

Conditional

  • Confirm project selected and category, actual, iteration are set
  • Confirm Milestone selected (if any)

Copy link

changeset-bot bot commented Jan 29, 2024

🦋 Changeset detected

Latest commit: 3511cb9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@equinor/fusion-framework-react-components-people-provider Patch
@equinor/fusion-framework-cli Patch
@equinor/fusion-framework-cookbook-app-react-feature-flag Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 👾 React 🚧 chore maintaines work, (update deps, workflos ...) labels Jan 29, 2024
@Noggling Noggling marked this pull request as ready for review January 29, 2024 09:59
@Noggling Noggling requested review from odinr and a team as code owners January 29, 2024 09:59
@Noggling Noggling self-assigned this Jan 29, 2024
Copy link
Contributor

github-actions bot commented Jan 29, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 4.8% 1288 / 26793
🔵 Statements 4.8% 1288 / 26793
🔵 Functions 5.99% 41 / 684
🔵 Branches 14.52% 106 / 730
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/react/components/people-resolver/src/PeopleResolverProvider.tsx 0% 0% 0% 0% 1-26
Generated in workflow #3942

Copy link
Contributor

@asbjornhaland asbjornhaland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can you rebase your branch? It is out of date with main.

@odinr odinr merged commit 09f8dd2 into main Feb 1, 2024
6 checks passed
@odinr odinr deleted the chore/remove-todo branch February 1, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 chore maintaines work, (update deps, workflos ...) 👾 React
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants