Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Purge secret ConnectionStrings--ResourcesDbContext for PR infra deployment #716

Closed

Conversation

Jonathanio123
Copy link
Collaborator

@Jonathanio123 Jonathanio123 commented Nov 6, 2024

  • New feature
  • Bug fix
  • High impact

Description of work:

When deploying infra IAC the PR env would fail because it would soft delete the secret but not purge it. With this PR it will also be purged.

Example of a pipeline run that fails
https://statoil-proview.visualstudio.com/Fusion%20Resource%20Allocation/_build/results?buildId=131253&view=logs&j=013c5867-0d4e-5d8f-4115-5efe4ac203c0&t=bc5fcbcb-7453-5c1d-5540-a7bbd223bfa7&s=2741fbd7-98d1-5541-d761-9bcc81bce3d2

I've circumvented this earlier by manually purging the secret myself

Testing:

  • Can be tested
  • Automatic tests created / updated
  • Local tests are passing

TODO:

Checklist:

  • Considered automated tests
  • Considered updating specification / documentation
  • Considered work items
  • Considered security
  • Performed developer testing
  • Checklist finalized / ready for review

@Jonathanio123 Jonathanio123 changed the title chore: Purge secret ConnectionStrings--ResourcesDbContext for PR infr… chore: Purge secret ConnectionStrings--ResourcesDbContext for PR infra deployment Nov 6, 2024
@Jonathanio123
Copy link
Collaborator Author

This is not the way

@Jonathanio123 Jonathanio123 deleted the chore/purge-pr-resources-connection-string branch November 6, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant