Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Increased time of delay for each retry of queued message (Provision) #595

Merged

Conversation

aleklundeq
Copy link
Collaborator

@aleklundeq aleklundeq commented Oct 2, 2023

  • New feature
  • Bug fix
  • High impact

AB#44549

Description of work:
Because there have been some requests that have timed out when running its natural cause and there are not obvious exceptions we will try to increase the amount of time we delay the retry. We increase from 10 seconds * retryCount to 30 seconds * retryCount. This means that we will wait around 4 minutes before retrying the last time (fourth time).

NB! The initial code did prepare scheduledTime to be increased 10 seconds for each retry, but the value was never assigned to retryMessage. We will still increase the delay to be 30 seconds for each try.

Testing:

  • Can be tested
  • Automatic tests created / updated
  • Local tests are passing

The function could be tested with natural processing of a request going through all the stages (create a new request, approve that request and then check that the request are beeing processed in provision). It is only when the provision-stage fails that we may experience the fix.

Checklist:

  • Considered automated tests
  • Considered updating specification / documentation
  • Considered work items
  • Considered security
  • Performed developer testing
  • Checklist finalized / ready for review

@aleklundeq aleklundeq marked this pull request as ready for review October 9, 2023 06:57
@aleklundeq aleklundeq changed the title feat: Increased time of delay for each retry of queued message (Provision) fix: Increased time of delay for each retry of queued message (Provision) Oct 9, 2023
@aleklundeq aleklundeq merged commit 5902c6d into master Oct 10, 2023
3 of 5 checks passed
@aleklundeq aleklundeq deleted the feat/increaseDelayTimeBetweenRetriesOfProvisionFunc branch October 10, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants