Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor everserver #9367

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor everserver #9367

wants to merge 1 commit into from
+484 −377

Conversation

frode-aarstad
Copy link
Contributor

@frode-aarstad frode-aarstad commented Nov 27, 2024 •
edited
Loading

Issue
Resolves #9290

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@frode-aarstad frode-aarstad marked this pull request as draft November 27, 2024 14:08
@frode-aarstad frode-aarstad force-pushed the refactor-everserver branch 2 times, most recently from 1f0ef43 to 080ce06 Compare November 28, 2024 12:00
@frode-aarstad frode-aarstad self-assigned this Nov 28, 2024
@frode-aarstad frode-aarstad added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Nov 28, 2024
@frode-aarstad frode-aarstad marked this pull request as ready for review November 28, 2024 12:17
@frode-aarstad frode-aarstad marked this pull request as draft November 28, 2024 12:18
@frode-aarstad frode-aarstad marked this pull request as ready for review November 28, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@frode-aarstad frode-aarstad

Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split everserver functionality between starting server and submitting experiment
1 participant
@frode-aarstad