Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin hypothesis #9321

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Unpin hypothesis #9321

merged 1 commit into from
Nov 27, 2024

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Nov 22, 2024

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@larsevj larsevj self-assigned this Nov 25, 2024
@larsevj larsevj added the release-notes:skip If there should be no mention of this in release notes label Nov 25, 2024
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to keep the lower bounds. What you want is

    "hypothesis!=6.102.0,>=5.49",
    "hypothesis>=6.11; python_version >= '3.12'",

pyproject.toml Outdated
@@ -96,7 +96,7 @@ Repository = "https://github.com/equinor/ert"
[project.optional-dependencies]
dev = [
"furo",
"hypothesis!=6.102.0,<6.112.3,>=5.49",
"hypothesis==5.49",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5.49 only works for python < 3.12

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was only checking. It does look like the test fail for python 3.11 for 5.49.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be as suggested now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, not sure why not, that feature has been in place since version 3. Maybe just try ==6.0.4 to see if that works? In which case you can use the lower bound >=6 instead of >=5.49.

Copy link
Contributor Author

@larsevj larsevj Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6.85 is the earliest version I manage to pass locally on python3.11

Copy link
Contributor

@eivindjahren eivindjahren Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then let's go for it

hypothesis!=6.102.0,!=6.112.3,>=6.85

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@larsevj larsevj force-pushed the unpin_hypothesis branch 2 times, most recently from 373e4f7 to 2e172a1 Compare November 26, 2024 09:20
@larsevj larsevj merged commit 398aa3e into equinor:main Nov 27, 2024
42 checks passed
@larsevj larsevj deleted the unpin_hypothesis branch November 27, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants