-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpin hypothesis #9321
Unpin hypothesis #9321
Conversation
011bf65
to
f8c0e0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to keep the lower bounds. What you want is
"hypothesis!=6.102.0,>=5.49",
"hypothesis>=6.11; python_version >= '3.12'",
f8c0e0e
to
56b4f17
Compare
pyproject.toml
Outdated
@@ -96,7 +96,7 @@ Repository = "https://github.com/equinor/ert" | |||
[project.optional-dependencies] | |||
dev = [ | |||
"furo", | |||
"hypothesis!=6.102.0,<6.112.3,>=5.49", | |||
"hypothesis==5.49", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5.49 only works for python < 3.12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I was only checking. It does look like the test fail for python 3.11 for 5.49.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be as suggested now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, not sure why not, that feature has been in place since version 3. Maybe just try ==6.0.4
to see if that works? In which case you can use the lower bound >=6
instead of >=5.49
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6.85 is the earliest version I manage to pass locally on python3.11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then let's go for it
hypothesis!=6.102.0,!=6.112.3,>=6.85
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
373e4f7
to
2e172a1
Compare
2e172a1
to
d001753
Compare
Issue
Resolves #my_issue
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"'
)When applicable