Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to serialize and deserialize ErtConfig #8820

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Make it possible to serialize and deserialize ErtConfig #8820

merged 3 commits into from
Nov 14, 2024

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Sep 30, 2024 •
edited
Loading

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@oyvindeide oyvindeide force-pushed the serialize_config branch 4 times, most recently from 38d6817 to 329b324 Compare October 5, 2024 17:21
@oyvindeide oyvindeide force-pushed the serialize_config branch 2 times, most recently from 13e520c to 6023e5e Compare October 22, 2024 10:15
@oyvindeide oyvindeide force-pushed the serialize_config branch 2 times, most recently from bb7aacf to 8ee5259 Compare November 13, 2024 12:55
@oyvindeide oyvindeide changed the title Serialize config Make it possible to serialize and deserialize ErtConfig Nov 13, 2024
@oyvindeide oyvindeide added the release-notes:improvement Automatically categorise as improvement in release notes label Nov 13, 2024
@oyvindeide oyvindeide force-pushed the serialize_config branch 3 times, most recently from f54d873 to 32d86da Compare November 13, 2024 15:12
sondreso
sondreso approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice job! 👏 🚀

@oyvindeide oyvindeide force-pushed the serialize_config branch 3 times, most recently from b0795b9 to 091ea1b Compare November 14, 2024 10:49
@oyvindeide oyvindeide enabled auto-merge (rebase) November 14, 2024 10:55
@oyvindeide oyvindeide merged commit 9a3c864 into equinor:main Nov 14, 2024
42 checks passed
@oyvindeide oyvindeide deleted the serialize_config branch November 14, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sondreso sondreso sondreso approved these changes

Assignees
No one assigned
Labels
release-notes:improvement Automatically categorise as improvement in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oyvindeide @sondreso