Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use builders in venting emitter tests #714

Merged
merged 4 commits into from
Nov 29, 2024

Conversation

frodehk
Copy link
Contributor

@frodehk frodehk commented Nov 26, 2024

246

Why is this pull request needed?

Yaml builders should replace the dtos (data transfer objects) in the current tests for venting emitters.

What does this pull request change?

  • Replace dtos with builders in tests for venting emitters
  • Delete old yaml "factory" for venting emitters
  • Delete utilities.py in ltp_export
  • Move common functions for ltp from LptTestHelper class up to conftest as a ltp_functions fixture

Issues related to this change:

https://github.com/orgs/equinor/projects/869/views/5?pane=issue&itemId=88720060&issue=equinor%7Cecalc-internal%7C246

@frodehk frodehk self-assigned this Nov 26, 2024
@frodehk frodehk requested a review from a team as a code owner November 26, 2024 15:15
@frodehk frodehk requested a review from a team as a code owner November 28, 2024 14:21
@frodehk frodehk merged commit da54989 into main Nov 29, 2024
8 checks passed
@frodehk frodehk deleted the 246-use-builders-in-venting-emitter-tests branch November 29, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants