Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments on public facing interface #32

Open
mgarciaclosas opened this issue Mar 7, 2023 · 3 comments
Open

Comments on public facing interface #32

mgarciaclosas opened this issue Mar 7, 2023 · 3 comments
Assignees

Comments

@mgarciaclosas
Copy link

  • don't wrap up subtitle (or use a logical break) "FAIR principles..."; could add "Following" before FAIR principles
    • The About botton doen't work - no page is uploaded
  • -In the consortium page, Confluence link goes to BCRPP and BRCRR link goes to Confluence
  • In Research studies - missing "s" after with data platformS; could add one sentence descriptor under each study (similar to consortia)
  • In DCEG publications, the downloaded study description file is not yet informative (TRUE/FALSE statements)
  • Datasets from publications - I tried to make a request but after hitting submit, it left me hanging)
  • I made a data access request - I submitted but did not get any confirmation and I could not download the JSON file
  • DAta Request form: can the investigators be added using a form rather than free text ? the description shoudl b Add ALL investigators (the verb is missing before ALL)
  •  "Authorship" - are we really going to ask that requestors add cohort/study representatives as authors ?  In any case, this should be part of the Data Sharing Agreement, not included here, as I hope this is not a requirement to share DCEG data.
    
@bkop-ds bkop-ds self-assigned this Mar 7, 2023
@tahearn
Copy link
Collaborator

tahearn commented Mar 7, 2023

Ben, I don't see the folder description for the folder Montse created, "garciacm_JNCI_2023-03"

@bkop-ds
Copy link
Collaborator

bkop-ds commented Mar 7, 2023

I see that too. I tried repeating it and I was able to upload. I see that the dictionary also didn't upload properly. I wonder if there was an error with the dictionary file that caused issues downstream. We will need to put in checks to make sure everything is uploading properly and inform the user if there was an error.

@bkop-ds
Copy link
Collaborator

bkop-ds commented Mar 7, 2023

  1. wrapping is dependent on screen size, it is now enlarged to reduce the chance of it wrapping
  2. About page should now work (might require a hard refresh to see the change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants