Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missed update from #837 #844

Closed
natac13 opened this issue Sep 9, 2024 · 2 comments · Fixed by #845
Closed

Missed update from #837 #844

natac13 opened this issue Sep 9, 2024 · 2 comments · Fixed by #845

Comments

@natac13
Copy link
Contributor

natac13 commented Sep 9, 2024

epic-stack/app/routes/_seo+/sitemap[.]xml.ts

Line 6 in c2e8ed6

const serverBuild = (await context.serverBuild) as ServerBuild

With the update from #837 I believe that the SEO sitemap configuration also needs an update to ensure it grabs the 'ServerBuild` from the return object
@kentcdodds
Copy link
Member

Could you open a pull request for this? Thanks!

@natac13
Copy link
Contributor Author

natac13 commented Sep 9, 2024

You bet! I'll have it to you by 1 est just have to wrap something up quick

@natac13 natac13 mentioned this issue Sep 9, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: serverBuild access in sitemap natac13/epic-stack
2 participants
@kentcdodds @natac13