Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ketcher doesn't trigger change event in macromolecule mode #5618

Closed
MariaDolotova opened this issue Oct 1, 2024 · 0 comments · Fixed by #6012
Closed

Ketcher doesn't trigger change event in macromolecule mode #5618

MariaDolotova opened this issue Oct 1, 2024 · 0 comments · Fixed by #6012
Assignees
@Drimodaren
Labels
bug Dev question User's Feedback
Milestone
Ketcher 2.28.0-rc...

Comments

@MariaDolotova
Copy link

How can I subscribe to Ketcher change event when using macromolecule mode.
I have used the demo stand, tried to subscribe to 'change', but it didn't work.
Please see the gif below.

ketcher_macromolecule_mode_change_event
@rrodionov91 rrodionov91 self-assigned this Oct 25, 2024
@rrodionov91 rrodionov91 added this to the Ketcher 2.28.0-rc.1 milestone Oct 25, 2024
@rrodionov91 rrodionov91 removed their assignment Oct 25, 2024
@rrodionov91 rrodionov91 moved this to To do in Ketcher Oct 25, 2024
@NataliaLoginova NataliaLoginova moved this from To do to In progress in Ketcher Nov 20, 2024
@Drimodaren Drimodaren linked a pull request Nov 26, 2024 that will close this issue
#5618 ketcher doesnt trigger change event in macromolecule mode #6012
Merged
9 tasks
NataliaLoginova pushed a commit that referenced this issue Nov 29, 2024
@Drimodaren
#5618 ketcher doesnt trigger change event in macromolecule mode (#6012)
4f28cec 
* testing PR

* change history

* fix error in global d ts

* fix after meeting

* fix after push

* update test

* fix after review

* fix after review

* fix after review

* change update dispatch

* fix after test ci cd

* add comments

* fix after falied test

---------

Co-authored-by: Andrey Menshikov <[email protected]>
@github-project-automation github-project-automation bot moved this from In progress to Ready for testing in Ketcher Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Drimodaren Drimodaren

Labels
bug Dev question User's Feedback
Projects
Ketcher
Status: Ready for testing
Milestone
Ketcher 2.28.0-rc.1 (Current)
Development

Successfully merging a pull request may close this issue.

#5618 ketcher doesnt trigger change event in macromolecule mode epam/ketcher
4 participants
@rrodionov91 @AlexeyGirin @MariaDolotova @Drimodaren