-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autotests: add tests for missed test cases based on done tickets for SMARTS #3581
Labels
Comments
9 tasks
Nitvex
pushed a commit
that referenced
this issue
Jan 4, 2024
…ets for smarts (#3710) * adding test for checking pasting as SMARTS feature * adding few tests for visual check * adding screenshots for tests from visual-check spec * adding tests for checking warnings - covering with test cases ticket number 3431 * adding tests to cover ticket 3459 and 3445 * removing unnecessary import * adding tests to cover ticket 3397 and 3408 * removing unnecessary import * adding tests to cover 3387, 3372, 3362 and 3340 * adding tests to cover ticket 3339 * adding tests to cover tickets 3338 and 3328 * adding tests to cover indigo issues 1358, 1332, 1321, 1316, 1281 and 1252 * - code refactoring * - working on comments; - added 2 expected snapshots * - code refactoring * - change name of function * - code refactoring --------- Co-authored-by: Urszula Gawlowska <[email protected]> Co-authored-by: Zhirnoff <[email protected]>
Zhirnoff
added a commit
that referenced
this issue
Jan 4, 2024
…ets for smarts (#3710) * adding test for checking pasting as SMARTS feature * adding few tests for visual check * adding screenshots for tests from visual-check spec * adding tests for checking warnings - covering with test cases ticket number 3431 * adding tests to cover ticket 3459 and 3445 * removing unnecessary import * adding tests to cover ticket 3397 and 3408 * removing unnecessary import * adding tests to cover 3387, 3372, 3362 and 3340 * adding tests to cover ticket 3339 * adding tests to cover tickets 3338 and 3328 * adding tests to cover indigo issues 1358, 1332, 1321, 1316, 1281 and 1252 * - code refactoring * - working on comments; - added 2 expected snapshots * - code refactoring * - change name of function * - code refactoring --------- Co-authored-by: Urszula Gawlowska <[email protected]> Co-authored-by: Zhirnoff <[email protected]>
Zhirnoff
added a commit
that referenced
this issue
Feb 3, 2024
…ets for smarts (#3710) * adding test for checking pasting as SMARTS feature * adding few tests for visual check * adding screenshots for tests from visual-check spec * adding tests for checking warnings - covering with test cases ticket number 3431 * adding tests to cover ticket 3459 and 3445 * removing unnecessary import * adding tests to cover ticket 3397 and 3408 * removing unnecessary import * adding tests to cover 3387, 3372, 3362 and 3340 * adding tests to cover ticket 3339 * adding tests to cover tickets 3338 and 3328 * adding tests to cover indigo issues 1358, 1332, 1321, 1316, 1281 and 1252 * - code refactoring * - working on comments; - added 2 expected snapshots * - code refactoring * - change name of function * - code refactoring --------- Co-authored-by: Urszula Gawlowska <[email protected]> Co-authored-by: Zhirnoff <[email protected]>
rrodionov91
pushed a commit
that referenced
this issue
Feb 5, 2024
- add tests for missed test cases based on done tickets for smarts (#3710) Co-authored-by: Urszula Gawlowska <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
List of SMARTS tickets which need autotests
Ketcher side issues:
together with
Bond is shifted when list of atoms (at least 3) or few general atom's properties are specified at label near to the next atom #3508 Bond is shifted when list of atoms (at least 3) or few general atom's properties are specified at label near to the next atom
Indigo side issues:
16. epam/Indigo#1358 Error while loading [!#6,!#7,!#8] smarts
17. epam/Indigo#1332 Aromatic atom list is not recognized in SMARTS query (saving and loading + test case with custom query with list of atoms in lowercase)
18. epam/Indigo#1321 When saving a structure with set up Implicit H count and any other atom attribute then an error appears (add to the query-specific-attributes.spec.ts test case for more then one attribute set up)
19. epam/Indigo#1316 SMARTS saver miss component level grouping (add that test case for saving and loading?)
20. epam/Indigo#1281 Support SMARTS "or unspecified" bond property in custom queries (???)
21. epam/Indigo#1254 SMARTS with component-level grouping saved without '()' (add some tests for saving and loading with different types of grouping?)
22. epam/Indigo#1252 SMARTS loader load grouped components as separate molecules (???)
The text was updated successfully, but these errors were encountered: