Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview: Reaction's name and conditions change places between parts of cascade reaction with Multi-Tailed and Single arrows after save/load to/from RDF or Layout actions #2643

Closed
ivanmaslow opened this issue Nov 20, 2024 · 3 comments · Fixed by #2640
Assignees
Labels
Bug Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: High

Comments

@ivanmaslow
Copy link
Collaborator

ivanmaslow commented Nov 20, 2024

Steps to Reproduce

  1. Add cascade reaction with Multi-Tailed/Single arrows and with Reaction's name and conditions to Canvas from ket:
    text-issue-1.zip
    image
  2. Make save/load to/from RDF or Layout actions

Actual Result

  • Name and conditions of the first reaction and second are switched:
    image

Expected Result

  • Reaction's name and conditions aren't switched
    image

Environment details

  • Tested on CI-CD SA environment with Ketcher-Master, Indigo-2404-ket-to-rdf branches;
  • Ketcher [Version 2.28.0-dev.1] Build at 2024-11-20; 02:19:06
  • Indigo Version 1.27.0-dev.1.37-gdee66d90-wasm32-wasm-clang-12.0.0
  • Desktop, Windows 11 Enterprise
  • Chrome Version 131.0.6778.70 (Official Build) (64-bit)

Notes

@ivanmaslow ivanmaslow added Bug Priority: High Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes labels Nov 20, 2024
@ivanmaslow ivanmaslow changed the title Reaction's name and conditions change places between parts of cascade reaction after save/load to/from RDF or Layout actions Reaction's name and conditions change places between parts of cascade reaction with Multi-Tailed and Single arrows after save/load to/from RDF or Layout actions Nov 20, 2024
@ivanmaslow
Copy link
Collaborator Author

ivanmaslow commented Nov 20, 2024

The fix is verified on on CI-CD SA environment with Ketcher-Master, Indigo-2404-ket-to-rdf branches:

  • Ketcher [Version 2.28.0-dev.1] Build at 2024-11-20; 09:14:36
  • Indigo Version 1.27.0-dev.1.38-g6c821972-wasm32-wasm-clang-12.0.0
  • Desktop, Windows 11 Enterprise
  • Chrome Version 131.0.6778.70 (Official Build) (64-bit)

Reaction's name and conditions aren't switched between cascade reaction's part after save and layout actions:
image
But it still doesn't work for additional case in notes.

@ivanmaslow
Copy link
Collaborator Author

ivanmaslow commented Nov 21, 2024

Retested on aws_ci SA env with Ketcher-master and Indigo-2404-ket-to-rdf branches:

  • Ketcher [Version 2.28.0-dev.1] Build at 2024-11-20; 19:58:39;
  • Indigo Version 1.27.0-dev.1.43-gec603913-wasm32-wasm-clang-12.0.0
  • Desktop, Windows 11 Enterprise
  • Chrome Version 131.0.6778.86 (Official Build) (64-bit)

It works correctly with most of cases, but there is an issue with this file:
!Synthia_path_8_tails.zip
image
After layout actions it looks different:
image
Also, there is another issue after save/load to/from RDF:
image
Also, ABS sign is on top - defect is reported - epam/ketcher#6004:
image
It works different on RC SA:
image

@even1024 even1024 linked a pull request Nov 22, 2024 that will close this issue
7 tasks
@ivanmaslow
Copy link
Collaborator Author

Retested on aws_ci SA env with Ketcher-master and Indigo-2404-ket-to-rdf branches:

  • Ketcher [Version 2.28.0-dev.1] Build at 2024-11-22; 06:47:10
  • Indigo Version 1.27.0-dev.1.49-gbbd67f22-wasm32-wasm-clang-12.0.0
  • Desktop, Windows 11 Enterprise
  • Chrome Version 131.0.6778.86 (Official Build) (64-bit)

The issue is fixed including the case for !Synthia_path_8_tails.zip:
image

@ivanmaslow ivanmaslow changed the title Reaction's name and conditions change places between parts of cascade reaction with Multi-Tailed and Single arrows after save/load to/from RDF or Layout actions Preview: Reaction's name and conditions change places between parts of cascade reaction with Multi-Tailed and Single arrows after save/load to/from RDF or Layout actions Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: High
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants