Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The arrow is displayed incorrect when import from rxn file #2478

Closed
AnnaKosol opened this issue Oct 3, 2024 · 2 comments · Fixed by #2580 or #2581
Closed

The arrow is displayed incorrect when import from rxn file #2478

AnnaKosol opened this issue Oct 3, 2024 · 2 comments · Fixed by #2580 or #2581
Assignees
@AliaksandrDziarkach
Labels
Bug Priority: High Team G
Milestone
Indigo-1.25.0-rc.5

Comments

@AnnaKosol
Copy link
Collaborator

Steps to Reproduce

  1. Add to Canvas the reaction
    The arrow is displayed incorrect when import from rxn file.zip
    (from the auto test File-Management/Open-And-Save-Files/Rxn-Files/rxn-files.spec.ts:258)

Actual behavior
Screenshot 2024-10-03 at 15 06 26

Expected behavior
Screenshot 2024-10-03 at 15 06 36

Environment details:

  • Ketcher Version 2.25.0-rc.2 Build at 2024-09-30; 09:14:32
  • Indigo Version 1.25.0-dev.2.7-g6118db71-wasm32-wasm-clang-12.0.0
  • MacOs 15
  • Version 129.0.6668.71 (Official Build) (arm64)
@AnnaKosol AnnaKosol added this to the Indigo-1.25.0-rc.2 milestone Oct 3, 2024
@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Oct 24, 2024 •
edited
Loading

Spread molecules to put default size arrow inside as per AlexanderSavelyev decision

AliaksandrDziarkach added a commit that referenced this issue Oct 24, 2024
@AliaksandrDziarkach
#2478 - The arrow is displayed incorrect when import from rxn file
31af061 
Fix code. Update UT
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Oct 24, 2024 that will close this issue
#2478 - The arrow is displayed incorrect when import from rxn file #2578
Closed
8 tasks
AliaksandrDziarkach added a commit that referenced this issue Oct 24, 2024
@AliaksandrDziarkach
#2478 - The arrow is displayed incorrect when import from rxn file
8c8cf30 
Fix code. Updated UT
@AliaksandrDziarkach AliaksandrDziarkach removed a link to a pull request Oct 24, 2024
#2478 - The arrow is displayed incorrect when import from rxn file #2578
Closed
8 tasks
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Oct 24, 2024 that will close this issue
#2478 - The arrow is displayed incorrect when import from rxn file #2580
Merged
8 tasks
AliaksandrDziarkach added a commit that referenced this issue Oct 24, 2024
@AliaksandrDziarkach
Backmerge: #2478 - The arrow is displayed incorrect when import from …
ec8ed1b 
…rxn file

Fix code. Updated UT
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Oct 24, 2024 that will close this issue
Backmerge: #2478 - The arrow is displayed incorrect when import from rxn file #2581
Merged
4 tasks
AlexanderSavelyev pushed a commit that referenced this issue Oct 25, 2024
@AliaksandrDziarkach
#2478 - The arrow is displayed incorrect when import from rxn file (#…
f3bf783 
…2580)
AlexanderSavelyev pushed a commit that referenced this issue Oct 25, 2024
@AliaksandrDziarkach
Backmerge: #2478 - The arrow is displayed incorrect when import from …
9b9895c 
…rxn file (#2581)
@ivanmaslow ivanmaslow mentioned this issue Oct 25, 2024
Closed
@Zhirnoff
Copy link
Collaborator

Tested. Bug fixed.
2024-11-11_16h41_22

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.26.0-rc.9]
Indigo version
[Version 1.25.0-rc.5]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliaksandrDziarkach AliaksandrDziarkach

Labels
Bug Priority: High Team G
Projects
None yet
Milestone
Indigo-1.25.0-rc.5
5 participants
@AliaksandrDziarkach @AlexeyGirin @Zhirnoff @AnnaKosol @AlekseiKhariukov