Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactions change the ordering on canvas after layout or save/load to/from RDF actions #2452

Closed
ivanmaslow opened this issue Sep 30, 2024 · 3 comments · Fixed by #2570
Closed
Assignees
Labels
Bug Cascade reactions Layout MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: Medium

Comments

@ivanmaslow
Copy link
Collaborator

Steps to Reproduce

  1. Add 2 reactions with Multi-Tailed Arrow and single arrow with shifted positions:
    image
  2. Click on Layout

Actual behavior

  • The first reaction becomes the second:
    image

Expected behavior

  • The first reaction should be the first as it was before layout action

Environment details

  • Detected on CI-CD environment with 2309-update-layout build
  • Ketcher [Version 2.25.0-rc.2] Build at 2024-09-30; 06:32:00
  • Version 1.25.0-dev.2.6-g0e1cfa10-wasm32-wasm-clang-12.0.0
  • Desktop, Windows 11 Enterprise
  • Chrome Version 129.0.6668.71 (Official Build) (64-bit)

Notes

  • Pay attention, that it should be tested for saving to RDF as well and should work as expected;
  • Issue is detected during exploratory testing of Import/Export for Multi-Tailed Arrow in cascade reactions - Import/export multi-tails in KET #2236
@ivanmaslow ivanmaslow added Bug Layout Priority: High Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes labels Sep 30, 2024
@ivanmaslow ivanmaslow added this to the Indigo-1.25.0-rc.1 milestone Sep 30, 2024
@ivanmaslow ivanmaslow changed the title Preview: Reactions changes the ordering on canvas after layout action Preview: Reactions change the ordering on canvas after layout action Oct 1, 2024
@yauhen-karmyzau
Copy link
Collaborator

Priority was changed to Medium as this case is not critical for initial requirements: more then one reaction on canvas.

@ivanmaslow ivanmaslow changed the title Preview: Reactions change the ordering on canvas after layout action Reactions change the ordering on canvas after layout action Oct 4, 2024
@ivanmaslow ivanmaslow changed the title Reactions change the ordering on canvas after layout action Reactions change the ordering on canvas after layout or save/load to/from RDF actions Oct 15, 2024
@ivanmaslow
Copy link
Collaborator Author

Pre-tested on aws_ci environment with Ketcher master and Indigo 2407-branch-ordering branches:

  • Ketcher [Version 2.26.0-rc.1] Build at 2024-10-24; 12:25:38;
  • Indigo Version 1.25.0-rc.3.18-gcdee98d4-wasm32-wasm-clang-12.0.0
  • Desktop, Windows 11 Enterprise
  • Chrome Version 130.0.6723.70 (Official Build) (64-bit)

Fixed for case in the defect:
image
image

But in case of a bigger quantity of reactions, it can be reproduced on layout or save/load to/from RDF - ordering is changed for reactions:
image
image
ketcher-2452.zip

@ivanmaslow
Copy link
Collaborator Author

The fix is verified on RC SA env:

  • Ketcher [Version 2.26.0-rc.6] Build at 2024-10-25; 09:57:12;
  • Indigo Version 1.25.0-rc.4.0-g8862ccb7e-wasm32-wasm-clang-19.0.0
  • Desktop, Windows 11 Enterprise
  • Chrome, Version 130.0.6723.70 (Official Build) (64-bit)

As mentioned above the case from the defect is fixed, but another issue is detected - #2584

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Cascade reactions Layout MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: Medium
Projects
None yet
4 participants