Dashboard Issues #11685
Dashboard Issues #11685
Conversation
MrFlashAccount
requested review from
PabloBuchu,
indiv0,
somebody1234,
Frizi,
farmaazon,
vitvakatu,
kazcw and
AdRiley
as code owners
MrFlashAccount
added
the
CI: No changelog needed
| const currentPlatform = platform() | ||
|
|
||
| document.documentElement.setAttribute('data-version', '%ENSO_IDE_VERSION%') | ||
| document.documentElement.classList.add(currentPlatform.toLowerCase()) |
There was a problem hiding this comment.
scuff
can we prefix the platform name please? so like platform-macos
There was a problem hiding this comment.
i guess mostly to indicate that they are variants of a single property (meaning that there shouldn't be more than one of platform- on any element)
There was a problem hiding this comment.
Not sure what you mean. I can specify macos:text-12 windows:text-24 linux:text-10. Yes, they exclude each other, but i don't understand how platform relates to it
There was a problem hiding this comment.
oh true 💀 this is a modifier/variant, not a property
but i think regardless it still makes sense to prefix the classes/variants just to make it clear that they are related to each other. just my two cents
also any prefix works, it doesn't have to be platform
| @@ -657,6 +657,10 @@ inset 0 -36px 51px -51px #00000014`, | |||
|
|
|||
| addVariant('not-focus', '&:where([data-rac]):not([data-focused])') | |||
| addVariant('not-selected', '&:where([data-rac]):not([data-selected])') | |||
|
|
|||
| addVariant('windows', '.windows &') | |||
| addVariant('macos', '.macos &') | |||
There was a problem hiding this comment.
if applying the prefix suggestion above then we should do it here too:
addVariant('platform-macos', 'html.platform-macos &')
🧪 Storybook is successfully deployed!📊 Dashboard:
|
Pull Request Description
Closes: https://github.com/enso-org/cloud-v2/issues/1592
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.