-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear cache on reload #11673
base: develop
Are you sure you want to change the base?
Clear cache on reload #11673
Conversation
|
||
@BuiltinMethod( | ||
type = "Runtime", | ||
name = "release_references", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, oh, a new builtin!
I tried to keep the conceptual surface of the reload button API as small as possible and exposing release_references
to general use goes against that.
I can see why it is useful in unit tests, but I hope we'll find another solution to the problem than a builtin available to everyone.
…into wip/gmt/11485-clear-cache
5b563d4
to
c493ec0
Compare
1fb2517
to
ef15d90
Compare
…into wip/gmt/11485-clear-cache
This uses #11577. It creates a reference to a value that is cleared on reload; this change detects this, and clears the cache.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.