Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear cache on reload #11673

Draft
wants to merge 29 commits into
base: develop
Choose a base branch
from
Draft

Clear cache on reload #11673

wants to merge 29 commits into from

Conversation

GregoryTravis
Copy link
Contributor

This uses #11577. It creates a reference to a value that is cleared on reload; this change detects this, and clears the cache.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.


@BuiltinMethod(
type = "Runtime",
name = "release_references",
Copy link
Member

@JaroslavTulach JaroslavTulach Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, oh, a new builtin!

I tried to keep the conceptual surface of the reload button API as small as possible and exposing release_references to general use goes against that.

I can see why it is useful in unit tests, but I hope we'll find another solution to the problem than a builtin available to everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants