Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment in GUI Styling #11465

Closed
wants to merge 17 commits into from
Closed

Experiment in GUI Styling #11465

wants to merge 17 commits into from

Conversation

jdunkerley
Copy link
Member

@jdunkerley jdunkerley commented Oct 31, 2024

Pull Request Description

  • Invert the colours of selected components.
  • Only show the halo for hovering over components.
  • Only show the halo on the top half of a component.
  • Show the visual cues for editing vectors and dropdowns when selecting a single component.
  • Vector editor to always show grab handle and also add a delete button.
  • Higher contrast for text / numeric input widgets to make them more prominent when editing.
  • Slight opacity in the visualization panel if not selected, so you can see things behind this.
  • The colour of the edges is from the source, not the target.
  • Edges going into components end as arrows.
  • When adding a new component, an arrow should point at the new component (not a connected line).

Not Implemented:

  • Red highlight on parameters when a missing value error.
  • Drop down indicator next to viz selector should be a lot clearer.
  • Right click to open the menu,
  • Copy component(s) in the menu.
  • If a default value Numeric/Text widget should be italic not bold.
  • Connections from the selected nodes should be in the lighter node.
  • @AdRiley to give a halo design.
  • Default cursor on the icon.

To Prototype:

  • Remove halo.
  • Components are read-only if not selected
  • Allowing moving around without a halo, by clicking anywhere in the node.
  • Potentially later ability to enable widgets by holding down a key.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@jdunkerley jdunkerley force-pushed the wip/jd/gui-selection branch 3 times, most recently from 19113c9 to 622961f Compare November 5, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant