Allow `(multi_value : Table) : Column` to succeed #11482

JaroslavTulach · 2024-11-04T13:55:29Z

The decision to support

Better UX for "types with multiple roles" in the IDE #11366

and especially handle the Treat single column Table as a Column request, we are going to use multi values representing multiple types at once.

Multi value & type check

When the library code needs, it can create a multi value representing both Table and Column at once. However, when there is a return value check like -> Table - such a value would be converted to just a table. That shall no longer be the case - we need multi values to pass thru. A solution for this has already been provided once:

Method return type checks avoid conversion when the type fits #10882

However such a solution worked poorly with potential static analysis.

Solution

The goal of this PR is to split the intersection type of an EnsoMultiValue into two parts:

the type checked one - a list of types whose methods are made available
the convertible one - a set of types this value can be converted ("cast") to

The text was updated successfully, but these errors were encountered:

enso-bot · 2024-11-12T04:45:12Z

Jaroslav Tulach reports a new STANDUP for yesterday (2024-11-11):

Progress: .

"multi value": Multi value Complex test and robustness refactoring #11525
preparing presentation for JavaDays
post review of read_many: Initial implementation of Data.read_many #11490 (comment)
(demo) meetings It should be finished by 2024-11-18.

Next Day: Being at javadays.cz conference

enso-bot · 2024-11-13T05:29:30Z

Jaroslav Tulach reports a new STANDUP for yesterday (2024-11-12):

Progress: .

at JavaDays.cz conference
errors & completions for NetBeans: Errors and completions in NetBeans 24+ #11531 It should be finished by 2024-11-18.

Next Day: Next day I will be working on the #11482 task. Delivering Enso talk at javadays.cz conference

enso-bot · 2024-11-14T04:51:02Z

Jaroslav Tulach reports a new STANDUP for yesterday (2024-11-13):

Progress: .

presentation about Enso at JavaDays.cz
everybody impressed
everybody loves the UI.
2 people would like to design a pipeline for their Java library in the IDE
they want to call the resulting program from their Java program
some want to find duplicities in Excel sheets - e.g. expert Excel users It should be finished by 2024-11-18.

Next Day: Next day I will be working on the #11482 task. Back to work

enso-bot · 2024-11-15T06:10:58Z

Jaroslav Tulach reports a new STANDUP for yesterday (2024-11-14):

Progress: .

debugging cycle in Truffle AST: Multi value Complex test and robustness refactoring #11525 (comment)
refactoring TypeCheck nodes: 1999523
review EnsoObject changes: https://github.com/enso-org/enso/pull/11538/files#r1841589783
update to VSCode&IGV extension merged and released (thanks to @ola): Errors and completions in NetBeans 24+ #11531 (comment)
getting up to date, (standup) meetings It should be finished by 2024-11-18.

Next Day: Finish type check refactoring, then up to

GitHub
Implement hasLanguage interop message for all enso objects by Akirathan · Pull Request #11538 · enso-org/enso
Blocks #11468 Pull Request Description This PR implements the Truffle contract that all the Enso objects must export hasLanguage and getLanguage messages. By refactoring EnsoObject from an interfac...

enso-bot · 2024-11-16T05:45:40Z

Jaroslav Tulach reports a new STANDUP for yesterday (2024-11-15):

Progress: .

new version of Enso VSCode extension is out (thanks to Ola)
watch my Enso demo at JavaDays.cz
solving "caching & refresh" via Ref: Refresh button should clear HTTP cache #11485 (comment)
ready for review: Multi value Complex test and robustness refactoring #11525
EnsoObject.Base prototype: https://github.com/enso-org/enso/pull/11538/files#r1843496148
turning EnsoObject into abstract class is OK
checking benchmark results - OK
writing a RefTest
meetings It should be finished by 2024-11-18.

GitHub
Implement hasLanguage interop message for all enso objects by Akirathan · Pull Request #11538 · enso-org/enso
Blocks #11468 Pull Request Description This PR implements the Truffle contract that all the Enso objects must export hasLanguage and getLanguage messages. By refactoring EnsoObject from an interfac...

enso-bot · 2024-11-19T06:41:46Z

Jaroslav Tulach reports a new STANDUP for yesterday (2024-11-18):

Progress: .

In-memory caches with Ref.new allow_gc=True: Enhance Managed_Resource to allow implementation of in-memory caches #11577
debugging Ref.modify: 38a20b4
addressing review comments: 4bc57ef
meetings, some 360 reviews It should be finished by 2024-11-25.

While working on #11482 and enhancing the tests suite with more tests based on `type Complex` a [getRootNode() did not terminate in 100000 iterations](#11525 (comment)) problem was discovered. Detailed investigation revealed that the existing `ReadArgumentCheckNode` infrastructure was able to create a **cycle** of parent pointers in the Truffle AST. The problem was in intricate manipulation of the AST while rewriting internals in `ReadArgumentCheckNode`. This PR avoids such manipulation by _refactoring the type checking code_. `ReadArgumentNode` knows nothing about types anymore. When a type check is needed, `IrToTruffle` adds additional `TypeCheckValueNode.wrap` around the `ReadArgumentNode` - that breaks the **vicious circle**. All the _type checks_ nodes are moved to its own package. All but one of the classes are made package private. The external API for doing _type checking_ is concentrated into `TypeCheckValueNode`.

enso-bot · 2024-11-20T06:31:52Z

Jaroslav Tulach reports a new STANDUP for yesterday (2024-11-19):

Progress: .

a day of CI fighting
Fixed Unexpected (42 : Text & Integer) signature at the end of a function #11574 by Allow (42 : Text & Integer) at the end of function #11588
reported Enso builtins & Enso methods: Enso builtins don't expose Enso methods #11589
attempt to fix Warnings displayed after main exit do not use defined to_text #11569 by Invoke Warning.getValue().to_text and use it from ReplDebuggerInstrument #11591
HostValueToEnsoNode move PR: HostValueToEnsoNode is not a builtin #11593
Fixed Hitting Debug.breakpoint with chrome inspector fails with NullPointerException #11362 by Give DebugBreakpointNode some section to prevent NPE #11594
review intersection types in the IDE: Deliver full intersection type of a value to the IDE #11583 (review)
libs standup It should be finished by 2024-11-25.

enso-bot · 2024-11-21T09:33:24Z

Jaroslav Tulach reports a new STANDUP for yesterday (2024-11-20):

Progress: .

EnsoMultiValue part I merged finally: Multi value Complex test and robustness refactoring #11525
CI fighting and bitching about it: https://discord.com/channels/401396655599124480/1201853512409939968/1308688656306929714
EnsoMultiValue part II PR created: Intersection types & type checks #11600
James force merged few PRs
investigated Could not load the cache metadata at Hello_World.meta in HelloWorldCacheTest #11196 and unassigned myself to allow re-planning
test for Invoke Warning.getValue().to_text and use it from ReplDebuggerInstrument #11591
caching via Ref.new: Enhance Managed_Resource to allow implementation of in-memory caches #11577 (comment)
meetings It should be finished by 2024-11-25.

Discord
Discord - Group Chat That’s All Fun & Games
Discord is great for playing games and chilling with friends, or even building a worldwide community. Customize your own space to talk, play, and hang out.

While working on #11482 and enhancing the tests suite with more tests based on `type Complex` a [getRootNode() did not terminate in 100000 iterations](#11525 (comment)) problem was discovered. Detailed investigation revealed that the existing `ReadArgumentCheckNode` infrastructure was able to create a **cycle** of parent pointers in the Truffle AST. The problem was in intricate manipulation of the AST while rewriting internals in `ReadArgumentCheckNode`. This PR avoids such manipulation by _refactoring the type checking code_. `ReadArgumentNode` knows nothing about types anymore. When a type check is needed, `IrToTruffle` adds additional `TypeCheckValueNode.wrap` around the `ReadArgumentNode` - that breaks the **vicious circle**. All the _type checks_ nodes are moved to its own package. All but one of the classes are made package private. The external API for doing _type checking_ is concentrated into `TypeCheckValueNode`.

enso-bot · 2024-11-22T04:50:59Z

Jaroslav Tulach reports a new STANDUP for yesterday (2024-11-21):

Progress: .

fix for TypeOfNode PR: Giving TypeOfNode richer query API #11618
review of Deliver full intersection type of a value to the IDE #11583 (review)
removing warning from Meta.type_of: https://github.com/enso-org/enso/pull/11618/files#r1852454514 It should be finished by 2024-11-25.

GitHub
Giving TypeOfNode richer query API by JaroslavTulach · Pull Request #11618 · enso-org/enso
Pull Request Description To help address #11481 and to simplify extracting of type information from EnsoMultiValue, let's enrich the public method API of TypeOfNode and then enhance it to allow...

enso-bot · 2024-11-23T06:16:57Z

Jaroslav Tulach reports a new STANDUP for yesterday (2024-11-22):

Progress: .

PR merged: Giving TypeOfNode richer query API #11618
polyfill4ydoc review: Ydoc library #11615 (review)
updated c780c37 to changes in develop branch
thinking of Enhance Managed_Resource to allow implementation of in-memory caches #11577 (comment)
thoughts about Ref memory policy: https://github.com/enso-org/enso/pull/ - upgrading libraries as Java modules: 986fb62
failed attempt to initialize services in build time: Package libraries Java code as Java Modules #10714 (comment) It should be finished by 2024-11-25.

GitHub
Pull requests · enso-org/enso
Enso Analytics is a self-service data prep and analysis platform designed for data teams. - Pull requests · enso-org/enso

Another step in the #11482 work. Avoid accessing internals of `EnsoMultiValue`. Use `TypeOfNode` methods (as provided by #11618) instead.

enso-bot · 2024-11-26T05:01:50Z

Jaroslav Tulach reports a new STANDUP for yesterday (2024-11-25):

Progress: .

More on EnsoMultiValue: Avoid exposing EnsoMultiValue getters #11642
improving failures with multi values: ba5953f
EqualsMultiValueTest: c2d1911
all unit tests are green: 02ec775
meetings It should be finished by 2024-11-30.

Another step in the #11482 work. Avoid accessing internals of `EnsoMultiValue`. Use `TypeOfNode` methods (as provided by #11618) instead.

enso-bot · 2024-11-28T06:05:01Z

Jaroslav Tulach reports a new STANDUP for yesterday (2024-11-27):

Progress: .

more consistency of multi values: Intersection types & type checks #11600 (comment)
Ref.button: https://github.com/enso-org/enso/pull/11673/files#r1859938114
Managed_Resource docs: 85e8b6d
(post) review of right associativity: : operator is left-associative #11671 (comment)
eliminate static methods note: https://github.com/enso-org/enso/pull/11501/files#r1859977201
meetings It should be finished by 2024-11-30.

GitHub
Clear cache on reload by GregoryTravis · Pull Request #11673 · enso-org/enso
This uses #11577. It creates a reference to a value that is cleared on reload; this change detects this, and clears the cache. Checklist Please ensure that the following checklist has been satisfie...

GitHub
More IR mini passes by Akirathan · Pull Request #11501 · enso-org/enso
Closes #11326 Pull Request Description Mega passes converted to minipasses in Passes.globalTypingPasses group:
  enso/engine/runtime-compiler/src/main/scala/org/enso/compiler/Passes.s...</div></blockquote>

enso-bot · 2024-11-29T05:55:09Z

Jaroslav Tulach reports a new STANDUP for yesterday (2024-11-28):

Progress: .

Using Managed_Resource inside of EnsoSecretHelper:https://github.com/enso-org/enso/pull/11577/files#r1862556500
not up to date alert proposal: Update syntax documenation #11462 (comment)
bug in parser reported: Parser crash when parsing == @Builtin_Method #11691
review MiniIRPass rewrite: More IR mini passes #11501 (review)
attempt at proper sources location (fails in VSCode) It should be finished by 2024-11-30.

GitHub
Enhance `Managed_Resource` to allow implementation of in-memory caches by JaroslavTulach · Pull Request #11577 · enso-org/enso
Pull Request Description Allows connection between refresh button and caches as requested by #11485:
please use Managed_Resource.new system_resource=True to create a reference that "can disap...

enso-bot · 2024-11-29T17:09:11Z

Jaroslav Tulach reports a new STANDUP for today (2024-11-29):

Progress: .

helping Radek with NI & Data.read: https://discord.com/channels/@me/964018046375190528/1312006376528150580
fix exception on missing module: Better Module_Does_Not_Exist exception #11713
addressing review comments: Intersection types & type checks #11600 (comment)
standups and discussions It should be finished by 2024-11-30.

Discord
Discord - Group Chat That’s All Fun & Games
Discord is great for playing games and chilling with friends, or even building a worldwide community. Customize your own space to talk, play, and hang out.

JaroslavTulach added the -compiler label Nov 4, 2024

github-project-automation bot added this to Issues Board Nov 4, 2024

github-project-automation bot moved this to ❓New in Issues Board Nov 4, 2024

JaroslavTulach mentioned this issue Nov 4, 2024

Ensure EnsoMultiValue returns some Meta.type_of #11480

Merged

2 tasks

JaroslavTulach self-assigned this Nov 5, 2024

JaroslavTulach mentioned this issue Nov 11, 2024

Multi value Complex test and robustness refactoring #11525

Merged

4 tasks

JaroslavTulach mentioned this issue Nov 25, 2024

Avoid exposing EnsoMultiValue getters #11642

Merged

2 tasks

mergify bot pushed a commit that referenced this issue Nov 25, 2024

Avoid exposing EnsoMultiValue getters (#11642)

1cc3848

Another step in the #11482 work. Avoid accessing internals of `EnsoMultiValue`. Use `TypeOfNode` methods (as provided by #11618) instead.

hubertp pushed a commit that referenced this issue Nov 26, 2024

Avoid exposing EnsoMultiValue getters (#11642)

1ea4d1a

Another step in the #11482 work. Avoid accessing internals of `EnsoMultiValue`. Use `TypeOfNode` methods (as provided by #11618) instead.

JaroslavTulach linked a pull request Nov 27, 2024 that will close this issue

Intersection types & type checks #11600

Open

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow `(multi_value : Table) : Column` to succeed #11482

Allow `(multi_value : Table) : Column` to succeed #11482

JaroslavTulach commented Nov 4, 2024

enso-bot bot commented Nov 12, 2024

enso-bot bot commented Nov 13, 2024

enso-bot bot commented Nov 14, 2024

enso-bot bot commented Nov 15, 2024 •

edited by unfurl-links bot

Loading

enso-bot bot commented Nov 16, 2024 •

edited by unfurl-links bot

Loading

enso-bot bot commented Nov 19, 2024

enso-bot bot commented Nov 20, 2024

enso-bot bot commented Nov 21, 2024 •

edited by unfurl-links bot

Loading

enso-bot bot commented Nov 22, 2024 •

edited by unfurl-links bot

Loading

enso-bot bot commented Nov 23, 2024 •

edited by unfurl-links bot

Loading

enso-bot bot commented Nov 26, 2024

enso-bot bot commented Nov 28, 2024 •

edited by unfurl-links bot

Loading

enso-bot bot commented Nov 29, 2024 •

edited by unfurl-links bot

Loading

enso-bot bot commented Nov 29, 2024 •

edited by unfurl-links bot

Loading

Allow (multi_value : Table) : Column to succeed #11482

Allow (multi_value : Table) : Column to succeed #11482

Comments

JaroslavTulach commented Nov 4, 2024

Multi value & type check

Solution

enso-bot bot commented Nov 12, 2024

enso-bot bot commented Nov 13, 2024

enso-bot bot commented Nov 14, 2024

enso-bot bot commented Nov 15, 2024 • edited by unfurl-links bot Loading

enso-bot bot commented Nov 16, 2024 • edited by unfurl-links bot Loading

enso-bot bot commented Nov 19, 2024

enso-bot bot commented Nov 20, 2024

enso-bot bot commented Nov 21, 2024 • edited by unfurl-links bot Loading

enso-bot bot commented Nov 22, 2024 • edited by unfurl-links bot Loading

enso-bot bot commented Nov 23, 2024 • edited by unfurl-links bot Loading

enso-bot bot commented Nov 26, 2024

enso-bot bot commented Nov 28, 2024 • edited by unfurl-links bot Loading

enso-bot bot commented Nov 29, 2024 • edited by unfurl-links bot Loading

enso-bot bot commented Nov 29, 2024 • edited by unfurl-links bot Loading

Allow `(multi_value : Table) : Column` to succeed #11482

Allow `(multi_value : Table) : Column` to succeed #11482

enso-bot bot commented Nov 15, 2024 •

edited by unfurl-links bot

Loading

enso-bot bot commented Nov 16, 2024 •

edited by unfurl-links bot

Loading

enso-bot bot commented Nov 21, 2024 •

edited by unfurl-links bot

Loading

enso-bot bot commented Nov 22, 2024 •

edited by unfurl-links bot

Loading

enso-bot bot commented Nov 23, 2024 •

edited by unfurl-links bot

Loading

enso-bot bot commented Nov 28, 2024 •

edited by unfurl-links bot

Loading

enso-bot bot commented Nov 29, 2024 •

edited by unfurl-links bot

Loading

enso-bot bot commented Nov 29, 2024 •

edited by unfurl-links bot

Loading