Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change method names #2

Open
MartijnR opened this issue Oct 18, 2016 · 2 comments
Open

change method names #2

MartijnR opened this issue Oct 18, 2016 · 2 comments

Comments

@MartijnR
Copy link
Member

MartijnR commented Oct 18, 2016

method names should not be capitalized

hareko#3

@MartijnR
Copy link
Member Author

also I think .Get(0|1|2) could be changed to:

  • .getXml()
  • .getXmlStr()
  • .getHtmlStr()

@MartijnR
Copy link
Member Author

maybe also change class name from MergeXML to MergeXml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant