Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023.9.0 shows duplicate names on Tasmota devices #247

Open
SirGoodenough opened this issue Sep 8, 2023 · 4 comments · Fixed by #249
Open

2023.9.0 shows duplicate names on Tasmota devices #247

SirGoodenough opened this issue Sep 8, 2023 · 4 comments · Fixed by #249

Comments

@SirGoodenough
Copy link

SirGoodenough commented Sep 8, 2023

I just loaded 2023.9.0 and I'm seeing duplicate Tasmota device names. Didn't see then 2023.8.4.

Running tasmota 13.1 firmware, the latest.

Screenshot_20230907_203156
Screenshot_20230907_202926

@SirGoodenough SirGoodenough changed the title 2023.8.0 shows duplicate names on Tasmota devices 2023.9.0 shows duplicate names on Tasmota devices Sep 8, 2023
@thecode
Copy link
Contributor

thecode commented Sep 8, 2023

This is due to home-assistant/core#98636 which changed entity names to comply with HA Entity naming guidelines. Issue should be better created at Home Assistant core, but to be honest it is probably going to stay like this as this was already finalized to be the standard.

I am using Tasmota as a custom component for now with this change reverted and initially did not want to release it, I have opened the repository, if you have the knowledge how to manually install a custom component you can use it until you find a better solution. I don't promise maintaining it for the long run as this is a short-term solution for me until I figure out how to bypass this.
https://github.com/thecode/ha-tasmota

@shaulbarlev
Copy link

very annoying indeed.

@emontnemery
Copy link
Owner

This is a result of Tasmota using FriendlyName1 as device name if no device name is configured.

The linked PR #249 makes the integration check if the tasmota device name is same as the tasmota friendly name 1, and if it is, marks that entity as the "main feature of the device" by setting the entity's friendly name to None.

@emontnemery
Copy link
Owner

The linked PR only fixes the problem for a device with a single relay where the device itself is unnamed, Home Assistant needs something like home-assistant/architecture#957 to fix this problem for devices with multiple relays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants