Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code style update #19

Open
kavimaluskam opened this issue Jul 19, 2017 · 1 comment
Open

Code style update #19

kavimaluskam opened this issue Jul 19, 2017 · 1 comment
Assignees
@kavimaluskam
Labels
enhancement help wanted

Comments

@kavimaluskam
Copy link
Collaborator

I am not sure how do you think about this @emkay
Anyway there are some suggestion below:

  1. use import over require
  2. use class extends React.Component over React.createClass
  3. separate the file over few components
@kavimaluskam kavimaluskam self-assigned this Jul 19, 2017
@kavimaluskam kavimaluskam mentioned this issue Jul 19, 2017
Open
2 tasks
@emkay
Copy link
Owner

emkay commented Jul 19, 2017 •
edited
Loading

  1. use import over require

My preference would be to use require. I don't really see any benefit in using import. Happy to concede on this point though because it doesn't matter a ton to me either way.

  1. use class extends React.Component over React.createClass

Sure! I have grown to really like class.

  1. separate the file over few components

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kavimaluskam kavimaluskam

Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emkay @kavimaluskam