-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Modal
and Memory::set_modal_layer
#5358
Open
lucasmerlin
wants to merge
8
commits into
master
Choose a base branch
from
lucas/modal
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview available at https://egui-pr-preview.github.io/pr/5358-lucas/modal |
lucasmerlin
force-pushed
the
lucas/modal
branch
from
November 14, 2024 11:42
7ff4093
to
d4019c3
Compare
lucasmerlin
force-pushed
the
lucas/modal
branch
from
November 14, 2024 13:12
a985092
to
bf4d7df
Compare
lucasmerlin
force-pushed
the
lucas/modal
branch
from
November 14, 2024 13:58
7ddcb87
to
3517f7c
Compare
lucasmerlin
force-pushed
the
lucas/modal
branch
from
November 14, 2024 15:11
b0f91a7
to
afea434
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5370 should be merged before this
This adds modals to egui.
This PR
Modal
structMemory::set_modal_layer
to limit focus to a layer and above (used by the modal struct, but could also be used by custom modal implementations)Memory::allows_interaction
to check if a layer is behind a modal layer, deprecatingLayer::allows_interaction
Current problems:
When a button is focused before the modal opens, it stays focused and you also can't hit tab to focus the next widget. Seems like focus is "stuck" on that widget until you hit escape. This might be related to Disabled widgets prevent focus from going to next widget #5359fixed!Possible future improvements:
window
should be made into a separate widget and added to the modal