Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmetic gui remarks #19

Closed
Roughtrade opened this issue Jul 9, 2020 · 5 comments
Closed

cosmetic gui remarks #19

Roughtrade opened this issue Jul 9, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@Roughtrade
Copy link

Roughtrade commented Jul 9, 2020

First of all thanks for the great software. The chinese original is very talkative and dont works without an internet connection. The rights request is also a joke. Your software is super exemplary !

Unfortunately now a few remarks:
The curve of the light intensity is not optimal for scaling. The blue curve and the dots are noticeably thicker than the others. Unfortunately, in the German translation the labels of the measured values are cut off on the left side. ( Android Version 1.4 )
Also a little translation failor: minute(s) in german Minute(n)
vor 1 hour(s) aktualisiert should be vor 1 Stunde(n)....
Screenshot_2020-07-09-20-43-45

Regards Peter

@emericg emericg self-assigned this Jul 10, 2020
@emericg emericg added the enhancement New feature or request label Jul 10, 2020
@emericg
Copy link
Owner

emericg commented Jul 10, 2020

Hi, thanks for the kind words!

The curve of the light intensity is not optimal for scaling

Yes that curve is always problematic, I'm not sure what to do about it.
It wasn't enabled in previous version because of the scaling issues, and the difficulty to show both the usual or regular low values that you can have inside (0-5k) and the immediate jumps to very high values if you have full sun or a lamp. I could maybe use a logarithmic scale but even with that we could see a lot of spikes with day/night cycles...
I've enabled it again in 0.14 due to popular demand and to gather feedback.

The blue curve and the dots are noticeably thicker than the others.

That was intended :p because water would be the principal data. But that can be modified.
Also what do you find about the dots? Right now there is an option but I'm contemplating removing them.

Unfortunately, in the German translation the labels of the measured values are cut off on the left side. ( A>ndroid Version 1.4 )

Thanks for the hour/minutes translations, that's the result of a recent change, they where indeed missing.

The labels cut of on the left side have been reported a couple of times too, but I don't really want to make them bigger because they would take half of the screens, and even more on little screens. Labels aren't more important than the values!
These abbreviations have been suggested before, what do you think?

Bodenfeuchtigkeit -> Just "Feuchtigkeit" or "Feucht." or maybe "Bodenfeucht."
Temperatur -> "Temp."
Lichtintensität -> "Lichtint." or only "Licht"
Fruchtbarkeit -> "Fruchtb."

@Roughtrade
Copy link
Author

Roughtrade commented Jul 10, 2020

This would I say:

Lichtintensität -> Luminanz or ( colloquially would be better: ) Leuchtkraft
Bodenfeuchtigkeit -> Bodenfeuchte ( grammatically correct )
Fruchtbarkeit -> Fertilität or ( colloquially would be better: ) Düngung
Temperatur -> Temperatur

@Roughtrade
Copy link
Author

Can the gaps in the daily histogram be closed by interpolation? The sensors continue to measure in the gaps. Apparently the hourly automatic measurement on my mobile phone does not work.

The original app seems to bridge these gaps by reading the history stored in the sensor.

The darker fields for the night hours, I suppose, should be adjustable. For example, when a plant is in the growth phase it needs 14-16 hours of light.

Screenshot_2020-07-10-17-08-12

Stay healty and ceep calm

Peter

@emericg
Copy link
Owner

emericg commented Aug 12, 2020

Can the gaps in the daily histogram be closed by interpolation? The sensors continue to measure in the gaps. Apparently the hourly automatic measurement on my mobile phone does not work.

It's really only for measurements, the other graph already interpolate values. The application doesn't work in the background (yet), so the hourly measurement apply to when the app is on screen. See #20.

The original app seems to bridge these gaps by reading the history stored in the sensor.

You can follow #12

The darker fields for the night hours, I suppose, should be adjustable. For example, when a plant is in the growth phase it needs 14-16 hours of light.

Maybe someday ^^ Right now there isn't much "per plant" settings, maybe if we have a plant database that would be an idea.

@emericg
Copy link
Owner

emericg commented Oct 1, 2020

Hi, I'm closing this issue because some things already made it to the current release and others are in the todo list. Thanks!

@emericg emericg closed this as completed Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants