Make custom malloc & realloc return aligned pointers #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue embench#116. Until now, malloc_beebs and realloc_beebs returned non-aligned pointer and this behaviour could result in a performance penalty in some tests that use the heap, especially when executed on some architectures. This commit makes malloc_beebs return pointers aligned to multiples of sizeof(void *), and also updates realloc_beebs to make use of that. To avoid breaking changes, the padding is added to heap_requested. This commit also makes the static array used as a heap in sglib-combined and huffbench aligned. This is obtained through the __attribute__((aligned)) directive as it seems to be well supported across compilers. Reported-by: Edward Jones Signed-off-by: Gianluca Andreotti <[email protected]>
|
Thanks for this. @PaoloS02 has checked it, and it works with GCC and Clang. Good to merge. |
hirooih
added a commit
to hirooih/embench-iot
that referenced
this pull request
Oct 16, 2021
The change on embench#138 make malloc() fail without this fix.
jeremybennett
pushed a commit
that referenced
this pull request
Oct 17, 2021
* tarfind: wraparound the size heap The change on #138 make malloc() fail without this fix. * assert heap_size is a mutiple of the pointer size
|
This fix only works if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #116.
Until now,
malloc_beebsandrealloc_beebsreturned non-aligned pointer and this behaviour could result in a performance penalty in some tests that use the heap, especially when executed on some architectures.This commit makes
malloc_beebsreturn pointers aligned to multiples ofsizeof(void *), and also updatesrealloc_beebsto make use of that.To avoid breaking changes, the padding is added to heap_requested.
This commit also makes the static array used as a heap in sglib-combined and huffbench aligned. This is obtained through the
__attribute__((aligned))directive as it seems to be well supported across compilers.