Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ws: Add autoReconnect option? #107

Open
crishoj opened this issue Jun 24, 2024 · 3 comments
Open

ws: Add autoReconnect option? #107

crishoj opened this issue Jun 24, 2024 · 3 comments

Comments

@crishoj
Copy link

crishoj commented Jun 24, 2024

After migrating from VueUse useWebSocket, I realized that EdenWS doesn't have an auto-reconnect option.

Would you welcome a PR adding an autoReconnect option?

@dandeduck
Copy link
Contributor

Makes sense, if you ask me, ws should accept the same options as the underlying ws implementation.

@crishoj
Copy link
Author

crishoj commented Jun 26, 2024

The auto-reconnect is not actually present in the underlying (bare) WebSocket, but since handling disconnects (by reconnecting) is a fairly common need, I think it could be warranted to add in Eden.

@dandeduck
Copy link
Contributor

ahh right, I think it would be welcome if you created a PR with it (But I'm not the maintainer or anything, I'll be happy to give you a review, but I cannot merge it of course)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants