Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing DT_MIPS_XHASH #569

Closed
rossburton opened this issue Oct 3, 2024 · 3 comments
Closed

Missing DT_MIPS_XHASH #569

rossburton opened this issue Oct 3, 2024 · 3 comments

Comments

@rossburton
Copy link

ENUM_D_TAG_COMMON is missing an entry for DT_MIPS_XHASH. For reasons best known to the binutils maintainers this isn't defined in the common elf.h but is defined and used in elf.c (and present in compiled MIPS binaries):

bfd/elf.c:#define DT_MIPS_XHASH          0x70000036

https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=bfd/elf.c;h=7d3d2063130bd3d5bd988207ca68b15f76ac85c8;hb=HEAD#l1760

LLVM has the same definition:

llvm/include/llvm/BinaryFormat/DynamicTags.def:MIPS_DYNAMIC_TAG(MIPS_XHASH, 0x70000036)        // GNU-style hash table with xlat.
@sevaa
Copy link
Contributor

sevaa commented Oct 22, 2024

@rossburton This was addressed.

@eliben
Copy link
Owner

eliben commented Oct 22, 2024

If this is fixed by #571, the issue can be closed

@rossburton
Copy link
Author

Looks right to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants