Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI action #2515

Merged
merged 5 commits into from
Dec 1, 2024
Merged

Update CI action #2515

merged 5 commits into from
Dec 1, 2024

Conversation

ctapmex
Copy link
Contributor

@ctapmex ctapmex commented Nov 20, 2024

  1. instead of gcc-10/clang-10, we use gcc-7/clang-7 as the minimum
  2. Removed the warnings from cmake enabled on github by default. The log was clogged and no other problems are visible
  3. hide the error of searching for the far2 version tag, otherwise it looks like a fatal error
  4. I explicitly prescribed the installation of dependencies for building python plugins, except for macos (I do not know the package names)
  5. Added a ban on launching CI in fork on push on master. This led to the fact that CI was started every time forks were synchronized (by default, CI is disabled for forks, but if you turn it on, then there is such a negative moment). There was really nothing to check this item yet

gcc-7/clang-7 is the minimum version of the compiler on which the entire far2l is built. And it is close to the behavior that you catch when building on mac os elcapitan, to those build errors.
with the help of small fixes, the build can be done on gcc-5, but without multiarc


  1. вместо gcc-10/clang-10 как минимальный используем gcc-7/clang-7
  2. убрал предупреждения от cmake, включенные на github по умолчанию. Засоряли лог и не видно других проблем
  3. спрятал ошибку поиска тега версии far2l, иначе выглядт как фатальная ошибка
  4. явно прописал установку зависимсотей для сборки плагинов питон, кроме macos (не знаю имена пакетов)
  5. добавлен запрет на запуск CI в fork на push on master. Это приводило к тому, что при каждой синхронизации форков запускался CI (по умолчанию CI для форков выключен, но если его включить, то есть такой негативный момент). Этот пункт реально пока не начем было проверить

gcc-7/clang-7 - минимальная версия компилятора на которой собирается весь far2l. И оно приближено к поведению, которое ты ловишь при сборке на macos elcapitan, к тем ошибкам сборки.
с помощью небольших исправлений сборку можно делать и на gcc-5, но без multiarc

@elfmz elfmz merged commit 1d8e238 into elfmz:master Dec 1, 2024
9 checks passed
@ctapmex ctapmex deleted the ci_update branch December 1, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants