Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eabase.h redefines NULL as 0, which silences some compiler warnings #2

Open
anomalous42 opened this issue Jan 20, 2020 · 0 comments
Open

Comments

@anomalous42
Copy link

anomalous42 commented Jan 20, 2020

eabase.h redefines NULL, which silences some compiler warnings. This is the code that does that: https://github.com/electronicarts/EABase/blob/master/include/Common/EABase/eabase.h#L65-L84

You can see the warnings in action by playing with the code at https://gcc.godbolt.org/z/UrrWs5

Maybe it should do #define NULL __null instead when using Clang? Or maybe just drop the #undef and wrap the definition in an #ifndef block, because gcc doesn't appear to have that problem any more?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant