Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash comparing designs with null data #295

Open
ekolis opened this issue Feb 4, 2024 · 1 comment
Open

Crash comparing designs with null data #295

ekolis opened this issue Feb 4, 2024 · 1 comment
Labels
bug NAGOT GICK FEL - Something went wrong!
Milestone

Comments

@ekolis
Copy link
Owner

ekolis commented Feb 4, 2024

Describe the bug
Load the attached game and the game crashes.

To Reproduce
Steps to reproduce the behavior:

  1. Load the attached game, turn 13, player 2.

Expected behavior
The turn loads.

Actual behavior
The game crashes with a null reference exception comparing two ship designs because their properties such as the hull are null. It seems that the design is not fully deserialized.

Screenshots
N/A

Additional context
N/A
Savegame.zip

@ekolis ekolis added the bug NAGOT GICK FEL - Something went wrong! label Feb 4, 2024
@ekolis ekolis added this to the alpha-10 milestone Feb 4, 2024
@ekolis ekolis added this to FrEee Core Feb 4, 2024
@github-project-automation github-project-automation bot moved this to To do in FrEee Core Feb 4, 2024
@ekolis
Copy link
Owner Author

ekolis commented Feb 5, 2024

I noticed that objects such as designs and planets belonging to other players that shouldn't be visible yet are showing up in the player savegames. That might be causing this bug.

@ekolis ekolis pinned this issue Feb 9, 2024
@ekolis ekolis unpinned this issue Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug NAGOT GICK FEL - Something went wrong!
Projects
Status: To do
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant