Path with spaces don't get processed correctly

[JakeBelanger]

Wrap the file names and paths with double quotes in runCommand so that they get interpreted correctly. The following worked for me:

runCommand(cmd, path, destination) {
    let workingDir = p.dirname(path);
    let fileName = p.basename(path).replace(singleSlash, '\\');
    let cmdArgs = `"${fileName}" "${destination}"`;

    return this.execute(cmd, cmdArgs, workingDir);
}

[nickperkinslondon]

Yes please. This is absolutely necessary. Lots of windows filenames have spaces in them -- it's very common! I can make it work by adding my own quotes, but it should happen automatically.

[jakesjews]

I'll definitely accept a PR for this if anyone wants to try it out

[jakesjews]

@nickperkinslondon can you see if version 4 fixes your issue?

[JakeBelanger]

It works, but now it brings up the issue of having to escape single and double quotes in file names. I haven't figured out how to do that properly, so for my use case, I just clean the file names before sending them. However, I do think a fully fledged samba client should be able to send those files without a problem.

Thanks for your work!