Images are not displayed properly

[ghost]

SUMMARY

Thorium Reader v1.1.1 does not display images properly (when the image does not fit the window), cropping part of the image.

STEPS TO REPRODUCE

1. Open a light novel EPUB file.
2. Adjusting the settings does not help.

OBSERVED RESULT

EXPECTED RESULT

(Readium Chrome app is being used in the below screenshot.)

OTHER INFORMATION

OS: Linux
EPUB used in the above examples: 痛いのは嫌なので防御力に極振りしたいと思います。８ (Wikipedia article)

[danielweck]

Thank you for the bug report!
Are you able to share the EPUB (privately, with Thorium devs), so we can test/debug at our end?

[ghost]

@danielweck
Okay.
Is this Keybase account yours? Can I send you the file through Keybase?

[danielweck]

Yes, that's me on KeyBase. Thank you!

[danielweck]

Using r2-testapp-js (which is based on the same rendering/layout engine as Thorium / readium-desktop), the initial image / chapter looks weird:

[danielweck]

Actually, all images look "corrupted", and it varies from time to time, for example I also get the following:

[danielweck]

Note that RTL (Right To Left) + VWM (Vertical Writing Mode) text rendering "works", but page/CSS-column navigation is broken, see:
readium/r2-navigator-js#42

[ghost]

For the time being, I recommend using the old version v1.0.0-alpha.2 in case someone is affected by #917 and/or readium/r2-navigator-js#42. The old version does not have these two bugs.

[danielweck]

Thanks for checking this! If I remember correctly, older versions of Chromium (which were shipped in older versions of Electron) used a different CSS Columns implementation, and unfortunately the new "improved" implementation broke RTL/VWM support. That being said, this is probably fixable, let's hope somebody manages to allocate dev time to find out what CSS computation needs fixing.

[danielweck]

The issue of corrupted images was fixed via f125118

[danielweck]

Image resizing is a broader issue that is discussed in ReadiumCSS (object-fit: contain and other authoring practices to prevent image breaking across page boundaries)

[ghost]

Thanks!

Where can I track the image resizing discussion? readium/readium-css/55 seems to be related but it has been closed.

(BTW Is 1.2.0 released? I see the tag here but it has no summary or installation files.)

[danielweck]

(BTW Is 1.2.0 released? I see the tag here but it has no summary or installation files.)

Official release (version 1.2.1):

https://github.com/readium/readium-desktop/releases/tag/v1.2.0

Latest builds:

https://github.com/readium/readium-desktop/releases

[danielweck]

Where can I track the image resizing discussion? readium/readium-css/55 seems to be related but it has been closed.

I wonder if this is related to readium/readium-css#50 ?