Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in Localization #105

Open
code-jenn-or opened this issue Nov 6, 2019 · 3 comments
Open

Add in Localization #105

code-jenn-or opened this issue Nov 6, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@code-jenn-or
Copy link
Contributor

This library looks promising: https://github.com/react-native-community/react-native-localize

But determine how we can help scaffold this out.

@code-jenn-or code-jenn-or added the enhancement New feature or request label Nov 6, 2019
@jsjoeio
Copy link
Contributor

jsjoeio commented Nov 20, 2019

From @cball

I’ve heard react-native-localize and i18n-js are the tried and true combo (theres an example in the react-native-localize github. this blog takes a slightly different approach, but either way it would be great to 1) nail down what to use and 2) implement it

big wins imo:

  • we write it the same way if other languages are required or not
  • better testing (we don’t test exact strings)
  • additional language support should be pretty easy to add in

@jsjoeio
Copy link
Contributor

jsjoeio commented Nov 20, 2019

@jsjoeio
Copy link
Contributor

jsjoeio commented Nov 20, 2019

Consider implementing react-native-localize and i18n-js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants