-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Reword database cli prompts for clarity #123
fix: Reword database cli prompts for clarity #123
Conversation
packages/create-bison-app/cli.js
Outdated
@@ -54,35 +55,40 @@ function generateQuestions(appName) { | |||
{ | |||
name: "db.dev.name", | |||
type: "input", | |||
message: "What is the local database name?", | |||
prefix: "The following link <link> will help you setup a new Postgres database if needed.\n\bThe name you will use for the new database (or current).\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about asking if they have Postgres setup first?
Do you have Postgres setup? y/n
(If the user answers no)
Visit https://github.com/echobind/bisonapp/blob/main/docs/postgres.md for instructions!
(If the user answers yes, prompt for the database info below).
I like that you added both Homebrew and Postgres.app docs. Could we create a parent Postgres
doc that links to each of those? That way, we can point users to a single place and they can choose how to proceed.
## Installing PostgreSQL | ||
|
||
1. Install using hombrew: `brew install postgres` | ||
2. Add a local user (we recommend creating as a superuser to keep setup simple): `create user postgres --superuser` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't the user called postgres
exist by default? Either way I recommend calling it something different.
@@ -0,0 +1,31 @@ | |||
# Postgres.app (Mac Only) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are great!
|
||
## Operating Systems: | ||
|
||
macOS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a bulleted list maybe?
|
||
## What is included: | ||
|
||
PostgreSQL Server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This area looks like it could use some formatting
description: "The database host", | ||
default: "localhost", | ||
}, | ||
{ | ||
name: "db.dev.port", | ||
type: "input", | ||
message: "What is the local database port?", | ||
prefix: "The port you will use for the new database (or current).\n", | ||
message: `${chalk.green("\b?")} Local database port`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looking good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved so this doesn't block merging, but the formatting and postgres comments are worth resolving.
We're going to be revisiting the CLI prompts / questions. |
Reword database cli prompts
Changes
Screenshots
Checklist
n/a
Fixes Issue47