Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TcsPreTranslator mentions hmsdegSystem #8

Open
grahambell opened this issue Jul 26, 2014 · 1 comment
Open

TcsPreTranslator mentions hmsdegSystem #8

grahambell opened this issue Jul 26, 2014 · 1 comment

Comments

@grahambell
Copy link
Contributor

The method translateTargetInformation looks like it is trying to convert XML so that it includes an hmsdegSystem element. Meanwhile hmsdegSystem has been replaced with spherSystem, so this code appears to be obsolete, but the class appears to still be live. It is written to check for conicSystem and namedSystem and not apply the hmsdegSystem change in these cases. Obviously it should not manipulate tleSystem coordinates either, so we need to exempt them here if this method is still being used. If it is not being used, on the other hand, it should be removed.

@timj
Copy link
Contributor

timj commented Jul 26, 2014

The original TCS DTD was based on work from Gemini. JAC made it a bit more generic by moving hmsdeg to spher to accomodate things like Galactic coordinates where hms makes no sense. Clearly not all the OT code followed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants