Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional --darksky-api-key #5

Open
royduin opened this issue Aug 21, 2020 · 2 comments
Open

Optional --darksky-api-key #5

royduin opened this issue Aug 21, 2020 · 2 comments

Comments

@royduin
Copy link

royduin commented Aug 21, 2020

When I don't specify the DARKSKY_API_KEY environment variable I'm getting an error:

gw2pvo: error: argument --darksky-api-key: expected one argument

That should be optional right?

@eNeRGy164
Copy link
Owner

It would be nice if it was optional, but the current way of defining the entrypoint arguments doesn't allow that.
As previously the dark-sky API was free for all, it was easy to just get an API key. Now it isn't anymore, but as I already have one, I didn't run into this yet.

I think to make this one optional, a script should be added that can detect the empty value and leave it out when calling the gw2pvo command.

@royduin
Copy link
Author

royduin commented Aug 24, 2020

So the easiest way is to share your API key with me right? 😋 I've put none as the API key for now, it keeps trying but it doesn't break so I'm good 😎 but it would be nice for them so I'm not spamming their API with an invalid key 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants