Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated items being retrieved in get_by #27

Open
Danwhy opened this issue Dec 14, 2018 · 0 comments
Open

Outdated items being retrieved in get_by #27

Danwhy opened this issue Dec 14, 2018 · 0 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@Danwhy
Copy link
Member

Danwhy commented Dec 14, 2018

The get_by function is returning old values of an entry if they match the clauses passed in and the most recent one does not. We need to check that the item being returned is the most recent, else we should return nil.

We can do this by performing a get call on the item's entry id once we have it, then comparing the results to make sure they match. This will add an extra query though, so it would be better to add this check to the original query. If anybody has time to make this improvement, please do.

@Danwhy Danwhy added bug Something isn't working in-progress labels Dec 14, 2018
@Danwhy Danwhy self-assigned this Dec 14, 2018
@Danwhy Danwhy added help wanted Extra attention is needed and removed in-progress labels Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant