[PoC] Migrate eslint and prettier to biome #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freiondrej
commented
Nov 29, 2024
| "noDuplicateObjectKeys": "error", | ||
| "noDuplicateParameters": "error", | ||
| "noEmptyBlockStatements": "error", | ||
| "noExplicitAny": "off", |
There was a problem hiding this comment.
I changed this from error to off, as I'm not sure if you'd like to use this in new code. If yes, then I'd change back to "error" and add inline biome-igore comments to the preexisting places.
freiondrej
commented
Nov 29, 2024
| "useValidTypeof": "error" | ||
| } | ||
| }, | ||
| "ignore": ["lib/consentomatic/**/*", "dist/**/*", "lib/filterlist-engine.ts"] |
There was a problem hiding this comment.
The lib/filterlist-engine.ts was not in ignored files, but biome warned that it's really big and as it's apparently autogenerated, I suppose we could ignore it even in eslint+prettier in case you don't want to go through with Biome :)
freiondrej
commented
Nov 29, 2024
| "addon/manifest.*.json", | ||
| "**/*.md", | ||
| "**/*.har", | ||
| "lib/filterlist-engine.ts" |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@muodov this is highly opinionated, so I fully understand if you don't want to go through with this, especially as other DDG repos are using a shared eslint, but please just give it a try, it's addictively fast 🤩 (~50ms vs 10s). In case you'd like to consider using Biome in other DDG repos too, they have eslint+prettier auto migration: https://biomejs.dev/guides/migrate-eslint-prettier/ (which is what I used here too, with just some small tweaks).