Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for DomActions.undoPrehide() #553

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add tests for DomActions.undoPrehide() #553

wants to merge 2 commits into from

Conversation

freiondrej
Copy link
Contributor

@freiondrej freiondrej commented Nov 29, 2024 •
edited
Loading

  • undoPrehide() was creating the style element if it didn't exist and then removed it (see first commit), so I added a createIfNotExists parameter to deactivate this behavior in this case, with function overloads to keep typescript happy

@freiondrej
Copy link
Contributor Author

test failure seems to be a random one, but I don't have rights to rerun it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@freiondrej