Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: straeto.is #368

Closed
wants to merge 1 commit into from
Closed

Conversation

seia-soto
Copy link
Contributor

@seia-soto seia-soto commented Feb 2, 2024

fixes #230

TODO

  • Test is failing
...rule result false

@seia-soto
Copy link
Contributor Author

seia-soto commented Feb 12, 2024

@muodov I figured out that the test is consistently failing because detectCmp is returning false. This was not due to web driver problem. However, adding a JavaScript code to minor consent might not a right decision. Do you mind if I add an eval call in this rule to check localStorage?

In the middle of their code:

            R.useMemo)(()=>{
                try {
                    let e = localStorage.getItem("cookies_accepted");
                    return JSON.parse(e || "[]")
                } catch (e) {
                    return []
                }
            }

@seia-soto
Copy link
Contributor Author

Also, adding a new stage called { "checkStorage": { "key": "_some_cookie_key_" } } might be helpful.

@seia-soto seia-soto closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site breakage: https://straeto.is/
1 participant