Skip to content

Commit

Permalink
feat: Remove BuildTask implementations (#305)
Browse files Browse the repository at this point in the history
* feat: Remove BuildTask implementations

- Ensure that dscom tlbembed task can be used via CLI
  (Changes introduced by @bclothier)
- Let dscom build assembly be present, even though unused
- Remove implementation of tasks
- Removed obsolete tests

Closes #280

* docs: Removed tool based switch, as native task is dropped

* chore: More Debug output

---------

Co-authored-by: Carsten Igel <[email protected]>
  • Loading branch information
carstencodes and Carsten Igel authored Nov 20, 2024
1 parent 7f035a0 commit 8fe6f66
Show file tree
Hide file tree
Showing 14 changed files with 47 additions and 1,887 deletions.
5 changes: 4 additions & 1 deletion .github/workflows/code-style.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@ jobs:
run: dotnet restore

- name: Check dotnet version
run: dotnet --version
run: |
dotnet --version
dotnet --list-runtimes
dotnet --list-sdks
continue-on-error: false

- name: Check code format (editorconfig)
Expand Down
19 changes: 0 additions & 19 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -272,24 +272,6 @@ The result should be a line as follows in your `.csproj` file:

**Note**: The extra attribute `NoWarn="NU1701"` is only required, if neither `.NET 4.8` nor `.NET 6.0` are targeted, since dotnet pack will currently not create a .NETStandard 2.0 compliant NuGet Package.

#### Using the native build task

The native build task is automatically selected, if a .NET 4.8 or .NET 6.0 assembly for Windows is being build using an x64 platform.

#### Using the CLI based task

The CLI task is automatically selected, if a .NET Standard 2.0 assembly is being build. It is also chosen if the target platform is set to x86.

#### Enforcing the usage of the CLI

It might be necessary to select the CLI based task. To do so, add the following property to your `.csproj` file:

```XML
<_DsComForceToolUsage>true</_DsComForceToolUsage>
```

This will enforce the usage of the DsCom as a command-line tool. Please note, that verbose logging will no longer be working.

#### Enforcing to stop the build, if an error occurs

The build tasks puts a warning to the build log, if the desired type library has not been created, even if the backend has reported a success.
Expand All @@ -309,7 +291,6 @@ The build task can be parameterized with the following [properties](https://lear
| **Name** | **Description** |
| ---------------------------------------------- | ---------------------------------------------------------------------------------------------- |
| _DsComTlbExt | Extension of the resulting type library. <br /> Default Value: `.tlb` |
| _DsComForceToolUsage | Use DsCom Exe files to create the TLB <br/> Default value: `false` |
| DsComTypeLibraryUniqueId | Overwrite the library UUID <br/> Default Value: Empty Guid |
| DsComOverideLibraryName | Overwrite the IDL name of the library. <br/> Default Value: Empty string |
| DsComRegisterTypeLibrariesAfterBuild | Use regasm call after the build to register type library after the build <br/> Default value: `false` |
Expand Down
385 changes: 0 additions & 385 deletions src/dscom.build/DefaultBuildContext.cs

This file was deleted.

161 changes: 0 additions & 161 deletions src/dscom.build/FileSystemChecks.cs

This file was deleted.

66 changes: 0 additions & 66 deletions src/dscom.build/IBuildContext.cs

This file was deleted.

69 changes: 0 additions & 69 deletions src/dscom.build/LoggingTypeLibExporterSink.cs

This file was deleted.

17 changes: 0 additions & 17 deletions src/dscom.build/System.Net.Http.cs

This file was deleted.

Loading

0 comments on commit 8fe6f66

Please sign in to comment.